linux-kernel - Re: [PATCH 1/8] dt-bindings: mailbox: mediatek: Add GCE header file for MT8196

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c3f52576-918d-4e0f-8247-46cb468e5c77@kernel.org>
Date: Thu, 21 Nov 2024 12:48:40 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Jason-JH Lin (林睿祥) <Jason-JH.Lin@...iatek.com>
Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
 Singo Chang (張興國) <Singo.Chang@...iatek.com>,
 "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
 "chunkuang.hu@...nel.org" <chunkuang.hu@...nel.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "simona@...ll.ch" <simona@...ll.ch>, "mchehab@...nel.org"
 <mchehab@...nel.org>, Moudy Ho (何宗原)
 <Moudy.Ho@...iatek.com>, Nancy Lin (林欣螢)
 <Nancy.Lin@...iatek.com>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
 "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
 "robh@...nel.org" <robh@...nel.org>,
 Project_Global_Chrome_Upstream_Group
 <Project_Global_Chrome_Upstream_Group@...iatek.com>,
 "airlied@...il.com" <airlied@...il.com>,
 "linux-arm-kernel@...ts.infradead.org"
 <linux-arm-kernel@...ts.infradead.org>,
 "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
 "jassisinghbrar@...il.com" <jassisinghbrar@...il.com>,
 "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Subject: Re: [PATCH 1/8] dt-bindings: mailbox: mediatek: Add GCE header file
 for MT8196

On 21/11/2024 11:51, Jason-JH Lin (林睿祥) wrote:
>>> Signed-off-by: Jason-JH.Lin <jason-jh.lin@...iatek.com>
>>> ---
>>>  .../dt-bindings/mailbox/mediatek,mt8196-gce.h | 1449
>>> +++++++++++++++++
>>>  1 file changed, 1449 insertions(+)
>>>  create mode 100755 include/dt-bindings/mailbox/mediatek,mt8196-
>>> gce.h
>>
>> Please run scripts/checkpatch.pl and fix reported warnings. Then
>> please
>> run 'scripts/checkpatch.pl --strict' and (probably) fix more
>> warnings.
>> Some warnings can be ignored, especially from --strict run, but the
>> code
>> here looks like it needs a fix. Feel free to get in touch if the
>> warning
>> is not clear.
>>
>> This goes with the binding.
>>
> 
> I thought I have done that, but I found a whitespace warning at #1328
> now. I'll fix that at the next version.
> Thanks for the reminder.

There are multiple errors, including executable permission. I don't
believe you run checkpatch.

Best regards,
Krzysztof