linux-kernel - Re: [PATCH 1/2] dt-bindings: interconnect: qcom: drop QPIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <22828bf2-45a7-464d-ae30-8224056d9f0f@kernel.org>
Date: Thu, 21 Nov 2024 18:39:30 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Raviteja Laggyshetty <quic_rlaggysh@...cinc.com>,
 Georgi Djakov <djakov@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Cc: Odelu Kukatla <quic_okukatla@...cinc.com>,
 Mike Tipton <quic_mdtipton@...cinc.com>, linux-arm-msm@...r.kernel.org,
 linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: interconnect: qcom: drop QPIC_CORE IDs

On 21/11/2024 18:27, Raviteja Laggyshetty wrote:
> QPIC resources are modeled as clks, therefore remove corresponding

s/clks/clocks/

> defines from the binding as they're unused.


As clocks where? Details are needed since you are affecting the ABI.

> 
> Signed-off-by: Raviteja Laggyshetty <quic_rlaggysh@...cinc.com>
> ---
>  include/dt-bindings/interconnect/qcom,sdx75.h | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
This does not build.

../drivers/interconnect/qcom/sdx75.c:906:10: error: ‘MASTER_QPIC_CORE’
undeclared here (not in a function); did you mean ‘MASTER_QPIC’?

Best regards,
Krzysztof