linux-kernel - Re: [PATCH v2 03/11] drm/msm: adreno: move features bits in a separate variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAF6AEGsr2WoOdytWzDU_TJJh4myPj3B943LMisxisnA45rLFKA@mail.gmail.com>
Date: Thu, 21 Nov 2024 11:48:28 -0800
From: Rob Clark <robdclark@...il.com>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Cc: Neil Armstrong <neil.armstrong@...aro.org>, Akhil P Oommen <quic_akhilpo@...cinc.com>, 
	Viresh Kumar <vireshk@...nel.org>, Nishanth Menon <nm@...com>, Stephen Boyd <sboyd@...nel.org>, 
	"Rafael J. Wysocki" <rafael@...nel.org>, Sean Paul <sean@...rly.run>, 
	Konrad Dybcio <konradybcio@...nel.org>, Abhinav Kumar <quic_abhinavk@...cinc.com>, 
	Marijn Suijten <marijn.suijten@...ainline.org>, David Airlie <airlied@...il.com>, 
	Simona Vetter <simona@...ll.ch>, Bjorn Andersson <andersson@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Connor Abbott <cwabbott0@...il.com>, linux-pm@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org, 
	dri-devel@...ts.freedesktop.org, freedreno@...ts.freedesktop.org, 
	devicetree@...r.kernel.org
Subject: Re: [PATCH v2 03/11] drm/msm: adreno: move features bits in a
 separate variable

On Thu, Nov 21, 2024 at 10:44 AM Dmitry Baryshkov
<dmitry.baryshkov@...aro.org> wrote:
>
> On Wed, Nov 20, 2024 at 10:54:24AM -0800, Rob Clark wrote:
> > On Wed, Nov 20, 2024 at 3:18 AM Dmitry Baryshkov
> > <dmitry.baryshkov@...aro.org> wrote:
> > >
> > > On Tue, Nov 19, 2024 at 06:56:38PM +0100, Neil Armstrong wrote:
> > > > Now the features defines have the right name, introduce a features
> > > > bitfield and move the features defines in it, fixing all code checking
> > > > for them.
> > > >
> > > > No functional changes intended.
> > >
> > > I think it might be better to squahs this patch into the previous one,
> > > it would simplify checking that we use .quirks for ADRENO_QUIRK_foo and
> > > .features for ADRENO_FEAT_bar.
> > >
> >
> > IMHO better to keep this separated
>
> If they are separated, it is easy to overlook presense of a statement
> checking .quirks against ADRENO_FEAT_bar.

Maybe just drop this patch.. we don't really have so many
quirks+features so a single bitmask is fine and avoids this
wrong-bitmask-problem in the first place.

BR,
-R

> >
> > But we don't have _that_ many features/quirks so I don't find
> > combining them all that problematic
> >
>
> --
> With best wishes
> Dmitry