linux-kernel - Re: [PATCH v2 2/2] ext4: protect ext4_release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202411221326.eoWoxSKf-lkp@intel.com>
Date: Fri, 22 Nov 2024 14:07:04 +0800
From: kernel test robot <lkp@...el.com>
To: Ojaswin Mujoo <ojaswin@...ux.ibm.com>, linux-ext4@...r.kernel.org,
	Jan Kara <jack@...e.com>
Cc: oe-kbuild-all@...ts.linux.dev, Ritesh Harjani <ritesh.list@...il.com>,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	Baokun Li <libaokun1@...wei.com>
Subject: Re: [PATCH v2 2/2] ext4: protect ext4_release_dquot against freezing

Hi Ojaswin,

kernel test robot noticed the following build errors:

[auto build test ERROR on tytso-ext4/dev]
[also build test ERROR on brauner-vfs/vfs.all jack-fs/for_next linus/master v6.12 next-20241121]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Ojaswin-Mujoo/quota-flush-quota_release_work-upon-quota-writeback/20241121-204331
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git dev
patch link:    https://lore.kernel.org/r/20241121123855.645335-3-ojaswin%40linux.ibm.com
patch subject: [PATCH v2 2/2] ext4: protect ext4_release_dquot against freezing
config: arc-randconfig-001-20241122 (https://download.01.org/0day-ci/archive/20241122/202411221326.eoWoxSKf-lkp@intel.com/config)
compiler: arc-elf-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241122/202411221326.eoWoxSKf-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411221326.eoWoxSKf-lkp@intel.com/

All errors (new ones prefixed by >>):

   fs/ext4/super.c: In function 'ext4_acquire_dquot':
>> fs/ext4/super.c:6912:13: error: 'freeze_protected' undeclared (first use in this function); did you mean 'freeze_processes'?
    6912 |         if (freeze_protected)
         |             ^~~~~~~~~~~~~~~~
         |             freeze_processes
   fs/ext4/super.c:6912:13: note: each undeclared identifier is reported only once for each function it appears in


vim +6912 fs/ext4/super.c

  6893	
  6894	static int ext4_acquire_dquot(struct dquot *dquot)
  6895	{
  6896		int ret, err;
  6897		handle_t *handle;
  6898	
  6899		handle = ext4_journal_start(dquot_to_inode(dquot), EXT4_HT_QUOTA,
  6900					    EXT4_QUOTA_INIT_BLOCKS(dquot->dq_sb));
  6901		if (IS_ERR(handle))
  6902			return PTR_ERR(handle);
  6903		ret = dquot_acquire(dquot);
  6904		if (ret < 0)
  6905			ext4_error_err(dquot->dq_sb, -ret,
  6906				      "Failed to acquire dquot type %d",
  6907				      dquot->dq_id.type);
  6908		err = ext4_journal_stop(handle);
  6909		if (!ret)
  6910			ret = err;
  6911	
> 6912		if (freeze_protected)
  6913			sb_end_intwrite(dquot->dq_sb);
  6914	
  6915		return ret;
  6916	}
  6917	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki