linux-kernel - Re: [PATCH] ASoC: mediatek: mt8188: Add error handling in mtk_dai_etdm_enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ac730eec-e447-495b-8637-9c11a268e371@web.de>
Date: Fri, 22 Nov 2024 11:52:44 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Zhu Jun <zhujun2@...s.chinamobile.com>, linux-sound@...r.kernel.org,
 linux-mediatek@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org,
 Matthias Brugger <matthias.bgg@...il.com>, Jaroslav Kysela <perex@...ex.cz>,
 Takashi Iwai <tiwai@...e.com>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ASoC: mediatek: mt8188: Add error handling in
 mtk_dai_etdm_enable_mclk

> Introduce error handling in mtk_dai_etdm_enable_mclk to ensure that
> the function returns immediately if mt8188_afe_set_clk_rate fails.

* I suggest to append parentheses to function names.

* How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?
  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.12#n145


Regards,
Markus