linux-kernel - Re: [RFC 3/6] lib: rspdm: Initial commit of Rust SPDM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241122173104.GA2432309@bhelgaas>
Date: Fri, 22 Nov 2024 11:31:04 -0600
From: Bjorn Helgaas <helgaas@...nel.org>
To: Alistair Francis <alistair@...stair23.me>
Cc: lukas@...ner.de, Jonathan.Cameron@...wei.com,
	linux-kernel@...r.kernel.org, rust-for-linux@...r.kernel.org,
	akpm@...ux-foundation.org, bhelgaas@...gle.com,
	linux-pci@...r.kernel.org, linux-cxl@...r.kernel.org,
	bjorn3_gh@...tonmail.com, ojeda@...nel.org, tmgross@...ch.edu,
	boqun.feng@...il.com, benno.lossin@...ton.me, a.hindborg@...nel.org,
	wilfred.mallawa@....com, alistair23@...il.com,
	alex.gaynor@...il.com, gary@...yguo.net, aliceryhl@...gle.com
Subject: Re: [RFC 3/6] lib: rspdm: Initial commit of Rust SPDM

On Fri, Nov 15, 2024 at 03:46:13PM +1000, Alistair Francis wrote:
> This is the initial commit of the Rust SPDM library. It is based on and
> compatible with the C SPDM library in the kernel (lib/spdm).

> +++ b/lib/Kconfig
> @@ -754,6 +754,23 @@ config SPDM
>  	  in .config.  Drivers selecting SPDM therefore need to also select
>  	  any algorithms they deem mandatory.
>  
> +config RSPDM
> +	bool "Rust SPDM"
> +	select CRYPTO
> +	select KEYS
> +	select ASYMMETRIC_KEY_TYPE
> +	select ASYMMETRIC_PUBLIC_KEY_SUBTYPE
> +	select X509_CERTIFICATE_PARSER
> +	depends on SPDM = "n"
> +	help
> +	  The Rust implementation of the Security Protocol and Data Model (SPDM)
> +	  allows for device authentication, measurement, key exchange and
> +	  encrypted sessions.
> +
> +	  Crypto algorithms negotiated with SPDM are limited to those enabled
> +	  in .config.  Drivers selecting SPDM therefore need to also select
> +	  any algorithms they deem mandatory.

Maybe this (and config SPDM) should be tweaked to mention drivers that
*depend* on SPDM or RSPDM, since they no longer use "select"?

PCI_CMA, which currently depends on SPDM, doesn't really look like a
"driver", so maybe it should say "users of SPDM" or "features
depending on SPDM" or something?