linux-kernel - Re: [RFC 2/6] drivers: pci: Change CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241122172354.GA2430869@bhelgaas>
Date: Fri, 22 Nov 2024 11:23:54 -0600
From: Bjorn Helgaas <helgaas@...nel.org>
To: Jonathan Cameron <Jonathan.Cameron@...wei.com>
Cc: Alistair Francis <alistair@...stair23.me>, lukas@...ner.de,
	linux-kernel@...r.kernel.org, rust-for-linux@...r.kernel.org,
	akpm@...ux-foundation.org, bhelgaas@...gle.com,
	linux-pci@...r.kernel.org, linux-cxl@...r.kernel.org,
	bjorn3_gh@...tonmail.com, ojeda@...nel.org, tmgross@...ch.edu,
	boqun.feng@...il.com, benno.lossin@...ton.me, a.hindborg@...nel.org,
	wilfred.mallawa@....com, alistair23@...il.com,
	alex.gaynor@...il.com, gary@...yguo.net, aliceryhl@...gle.com
Subject: Re: [RFC 2/6] drivers: pci: Change CONFIG_SPDM to a dependency

On Fri, Nov 22, 2024 at 03:30:40PM +0000, Jonathan Cameron wrote:
> 
> > > diff --git a/lib/Kconfig b/lib/Kconfig
> > > index 68f46e4a72a6..4db9bc8e29f8 100644
> > > --- a/lib/Kconfig
> > > +++ b/lib/Kconfig
> > > @@ -739,6 +739,21 @@ config LWQ_TEST
> > >  	help
> > >            Run boot-time test of light-weight queuing.
> > >  
> > > +config SPDM
> > > +	bool "SPDM"  
> > 
> > If this appears in a menuconfig or similar menu, I think expanding
> > "SPDM" would be helpful to users.
> 
> Not sure it will!  Security Protocol and Data Model
> which to me is completely useless for hinting what it is ;)
> 
> Definitely keep (SPDM) on end of expanded name as I suspect most
> people can't remember the terms (I had to look it up ;)

Agree that the expansion doesn't add a whole lot, but I do think the
unadorned "SPDM" config prompt is not quite enough since this is in
the "Library routines" section and there's no useful context at all.

Maybe a hint that it's related to PCIe (although I'm not sure it's
*only* PCIe?) or device authentication or even some kind of general
"security" connection?

I admit that you're in good company; "parman" and "objagg" have zero
context and not even any help text at all.

Bjorn