linux-kernel - Re: [PATCH v3 10/10] ARM: dts: ti: omap: samsung-espresso10: Add initial support for Galaxy Tab 2 10.1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241123200202.684d8bc5@akair>
Date: Sat, 23 Nov 2024 20:02:02 +0100
From: Andreas Kemnade <andreas@...nade.info>
To: Mithil Bavishi <bavishimithil@...il.com>
Cc: Laurent.pinchart@...asonboard.com, aaro.koskinen@....fi,
 airlied@...il.com, conor+dt@...nel.org, devicetree@...r.kernel.org,
 dri-devel@...ts.freedesktop.org, jernej.skrabec@...il.com, jonas@...boo.se,
 khilman@...libre.com, krzk+dt@...nel.org, linux-hardening@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-omap@...r.kernel.org,
 maarten.lankhorst@...ux.intel.com, mripard@...nel.org,
 neil.armstrong@...aro.org, prabhakar.mahadev-lad.rj@...renesas.com,
 quic_jesszhan@...cinc.com, rfoss@...nel.org, robh@...nel.org,
 rogerq@...nel.org, simona@...ll.ch, thierry.reding@...il.com,
 tony@...mide.com, tzimmermann@...e.de
Subject: Re: [PATCH v3 10/10] ARM: dts: ti: omap: samsung-espresso10: Add
 initial support for Galaxy Tab 2 10.1

Am Sat, 23 Nov 2024 17:52:58 +0000
schrieb Mithil Bavishi <bavishimithil@...il.com>:

> > > +&i2c3 {
> > > +	touchscreen: synaptics-rmi4-i2c@20 {  
> >
> > touchscreen@20  
> Fixed, generic node names right!
> 
> > > +		avdd-supply = <&reg_touch_ldo_en>;  
> > not known in schema  
> I cannot seem to find the "vio-supply" shown in the bindings. There is
> only mention of avdd-supply and vdd-supply. I am not sure if avdd and
> vio are equivalent, hence the confusion.
> What should be the solution here?
> 
well, look at the schematics and see how it is wired ;-) 
Without schematic, it is a bit tricky. So you can look how it is used.
vdd-supply sounds like something to make the chip fully functional.
vio-supply seems to be for the io lines.  As the vendor kernel seem to
set i2c to gpio mode, so probably because the vio-supply is powered
down according to the board file you posted.
So it might be vio-supply only or vio and vdd-supply combined.
In any case document what you have seen in the vendor kernel.

> > Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml:
> > horizontal resolution of touchscreen (maximum x coordinate reported + 1)  
> 
> > So this touchscreen reports max 1278?  
> 
> Fixed it as well, 1280 and 800 respectively.
> https://github.com/Unlegacy-Android/android_kernel_ti_omap4/blob/3.4/common/arch/arm/mach-omap2/board-espresso-input.c#L264
> 
> > And these things belong below rm4-f11 according to
> > Documentation/devicetree/bindings/input/syna,rmi4.yaml  
> 
> I did not quite understand what you mean by this. I checked the bindings 
> and a few examples, there is nothing "below" rmi4-f11.
> 
this part of the binding description
patternProperties:
  "^rmi4-f1[12]@1[12]$":
    type: object
    unevaluatedProperties: false
    $ref: /schemas/input/touchscreen/touchscreen.yaml#
    description:

basically says that standard touchscreen properties are accepted below
rmi4-f11. 

In the example you have:
           rmi4-f11@11 {
                reg = <0x11>;
                touchscreen-inverted-y;
                syna,sensor-type = <2>;
            };

Regards,
Andreas