linux-kernel - Re: [PATCH v3 10/10] ARM: dts: ti: omap: samsung-espresso10: Add initial support for Galaxy Tab 2 10.1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241123192633.2049-1-bavishimithil@gmail.com>
Date: Sat, 23 Nov 2024 19:26:33 +0000
From: Mithil Bavishi <bavishimithil@...il.com>
To: andreas@...nade.info
Cc: Laurent.pinchart@...asonboard.com,
	aaro.koskinen@....fi,
	airlied@...il.com,
	bavishimithil@...il.com,
	conor+dt@...nel.org,
	devicetree@...r.kernel.org,
	dri-devel@...ts.freedesktop.org,
	jernej.skrabec@...il.com,
	jonas@...boo.se,
	khilman@...libre.com,
	krzk+dt@...nel.org,
	linux-hardening@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	linux-omap@...r.kernel.org,
	maarten.lankhorst@...ux.intel.com,
	mripard@...nel.org,
	neil.armstrong@...aro.org,
	prabhakar.mahadev-lad.rj@...renesas.com,
	quic_jesszhan@...cinc.com,
	rfoss@...nel.org,
	robh@...nel.org,
	rogerq@...nel.org,
	simona@...ll.ch,
	thierry.reding@...il.com,
	tony@...mide.com,
	tzimmermann@...e.de
Subject: Re: [PATCH v3 10/10] ARM: dts: ti: omap: samsung-espresso10: Add initial support for Galaxy Tab 2 10.1

> well, look at the schematics and see how it is wired ;-)

Schematic mentions vddtx, vdda, vdd and vbus, so unsure about that.
VDDTX is the one with 2.8V, VDD and VBUS are at 1.8V and VDDA is grounded,
it just gets the input from GDNA from the same touch sensor.

> As the vendor kernel seem to
> set i2c to gpio mode, so probably because the vio-supply is powered
> down according to the board file you posted.
> So it might be vio-supply only or vio and vdd-supply combined.
> In any case document what you have seen in the vendor kernel.

https://github.com/Unlegacy-Android/android_kernel_ti_omap4/blob/3.4/common/arch/arm/mach-omap2/board-espresso-input.c
This just makes it more confusing. Very confused on what is what now xD.
reg_touch_ldo_en is 2.8V which goes to VDDTX, it is gpmc_nwp.gpio_54 - TSP_LDO_ON
ldo6 is 1.8V presumably ldo6 (VAP_IO_1.8V) which goes to VDD, VBUS.

> basically says that standard touchscreen properties are accepted below
> rmi4-f11. 

But we do not use any of those properties. If you're talking about the
touchscreen-size-x/y, even in the examples those are out of rmi4-f11, in
the parent node.

Best Regards,
Mithil