linux-kernel - Re: [PATCH v2 07/12] can: ifi_canfd: fix {rx,tx}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c7db1eb8-3ecd-4c21-a393-54130e4a4857@denx.de>
Date: Sat, 23 Nov 2024 21:14:41 +0100
From: Marek Vasut <marex@...x.de>
To: Dario Binacchi <dario.binacchi@...rulasolutions.com>,
 linux-kernel@...r.kernel.org
Cc: linux-amarula@...rulasolutions.com, Marc Kleine-Budde
 <mkl@...gutronix.de>, Uwe Kleine-König
 <u.kleine-koenig@...libre.com>, Vincent Mailhol
 <mailhol.vincent@...adoo.fr>, linux-can@...r.kernel.org
Subject: Re: [PATCH v2 07/12] can: ifi_canfd: fix {rx,tx}_errors statistics

On 11/22/24 11:15 PM, Dario Binacchi wrote:
> The ifi_canfd_handle_lec_err() function was incorrectly incrementing only
> the receive error counter, even in cases of bit or acknowledgment errors
> that occur during transmission. The patch fixes the issue by incrementing
> the appropriate counter based on the type of error.
> 
> Fixes: 5bbd655a8bd0 ("can: ifi: Add more detailed error reporting")
> Signed-off-by: Dario Binacchi <dario.binacchi@...rulasolutions.com>
The multitude of if (likely(skb)) in the patch is super-ugly, but I do 
agree the change itself seems valid to me, so:

Reviewed-by: Marek Vasut <marex@...x.de>

Thanks !