linux-kernel - Re: [PATCH v1 1/1] x86/Documentation: Update algo in init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <C76B9F75-2708-4161-A130-8258981D5DF3@zytor.com>
Date: Mon, 25 Nov 2024 12:55:25 -0800
From: "H. Peter Anvin" <hpa@...or.com>
To: Ingo Molnar <mingo@...nel.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
CC: Randy Dunlap <rdunlap@...radead.org>, linux-kernel@...r.kernel.org,
        linux-doc@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
        Jonathan Corbet <corbet@....net>, Cloud Hsu <cloudhsu@...gle.com>,
        Chris Koch <chrisko@...gle.com>
Subject: Re: [PATCH v1 1/1] x86/Documentation: Update algo in init_size description of boot protocol

On November 25, 2024 12:43:37 PM PST, Ingo Molnar <mingo@...nel.org> wrote:
>
>* Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:
>
>> On Mon, Nov 25, 2024 at 09:45:36AM +0100, Ingo Molnar wrote:
>> > * Randy Dunlap <rdunlap@...radead.org> wrote:
>> > > On 11/25/24 12:31 AM, Andy Shevchenko wrote:
>> 
>> ...
>> 
>> > > > -	if (relocatable_kernel)
>> > > > -	runtime_start = align_up(load_address, kernel_alignment)
>> > > > -	else
>> > > > -	runtime_start = pref_address
>> > > > +    if ( relocatable_kernel ) {
>> > > > +      if ( load_address < pref_address )
>> > > 
>> > > What's up with the extra spaces around ( and ) ... and inconsistent with
>> > > the lines below?
>> 
>> I can remove them. This file has a lot of inconsistencies it seems...
>
>Feel free to send a followup patch that fixes up all of those other 
>details and harmonizes the style. Quality of the boot protocol 
>documentation demonstrably matters quite a bit in functional terms as 
>well ...
>
>> 
>> > Also, even pseudocode should follow the kernel's coding style and use 
>> > tabs in particular - which it already does in (some...) other places of 
>> > this document, such as the 'Sample Boot Configuration' chapter.
>> 
>> The problem is that reStructuredText syntax requires that indentation.
>> I may follow the rules after the rST requirements, though.
>
>That's a good solution - thank you!
>
>	Ingo

I, too, would really appreciate help in cleaning up the document and yes, the number of inconsistencies that have crept in over the years is quite frankly embarrassing. In a few places I will admit to thinking "did I actually write this?"

And as Ingo says, it matters, because experience shows that boot loader authors don't ask for clarification, they make their own interpretation and now we are stuck with a legacy. 

One part of the problem is that reviewing documentation changes in patch form hides inconsistencies because you only get a few lines of context.

On top of that, it would be great if the markup language could be used to insert rationale and commentary into the document. In some cases I think it would really help getting better compliance with the spec as intended, explain why we make certain recommendations as opposed to "well it seems to work", and help catch inconsistencies.