linux-kernel - Re: [PATCH v1 1/1] x86/Documentation: Update algo in init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z0TheZLKzwqnoZfE@gmail.com>
Date: Mon, 25 Nov 2024 21:43:37 +0100
From: Ingo Molnar <mingo@...nel.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Randy Dunlap <rdunlap@...radead.org>, linux-kernel@...r.kernel.org,
	linux-doc@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
	Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
	"H. Peter Anvin" <hpa@...or.com>, Jonathan Corbet <corbet@....net>,
	Cloud Hsu <cloudhsu@...gle.com>, Chris Koch <chrisko@...gle.com>
Subject: Re: [PATCH v1 1/1] x86/Documentation: Update algo in init_size
 description of boot protocol


* Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:

> On Mon, Nov 25, 2024 at 09:45:36AM +0100, Ingo Molnar wrote:
> > * Randy Dunlap <rdunlap@...radead.org> wrote:
> > > On 11/25/24 12:31 AM, Andy Shevchenko wrote:
> 
> ...
> 
> > > > -	if (relocatable_kernel)
> > > > -	runtime_start = align_up(load_address, kernel_alignment)
> > > > -	else
> > > > -	runtime_start = pref_address
> > > > +    if ( relocatable_kernel ) {
> > > > +      if ( load_address < pref_address )
> > > 
> > > What's up with the extra spaces around ( and ) ... and inconsistent with
> > > the lines below?
> 
> I can remove them. This file has a lot of inconsistencies it seems...

Feel free to send a followup patch that fixes up all of those other 
details and harmonizes the style. Quality of the boot protocol 
documentation demonstrably matters quite a bit in functional terms as 
well ...

> 
> > Also, even pseudocode should follow the kernel's coding style and use 
> > tabs in particular - which it already does in (some...) other places of 
> > this document, such as the 'Sample Boot Configuration' chapter.
> 
> The problem is that reStructuredText syntax requires that indentation.
> I may follow the rules after the rST requirements, though.

That's a good solution - thank you!

	Ingo