linux-kernel - Re: [PATCH 3/3] objtool: Add noinstr validation for static branches/calls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202411251459.P7KctSbw-lkp@intel.com>
Date: Mon, 25 Nov 2024 15:08:13 +0800
From: kernel test robot <lkp@...el.com>
To: Josh Poimboeuf <jpoimboe@...nel.org>,
	Valentin Schneider <vschneid@...hat.com>
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	linux-kernel@...r.kernel.org, Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH 3/3] objtool: Add noinstr validation for static
 branches/calls

Hi Josh,

kernel test robot noticed the following build errors:

[auto build test ERROR on linus/master]
[also build test ERROR on v6.12 next-20241122]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Josh-Poimboeuf/jump_label-Add-annotations-for-validating-noinstr-usage/20241125-105905
base:   linus/master
patch link:    https://lore.kernel.org/r/b5746646456eb030673cdb62c23d69ed83c2702a.1732326588.git.jpoimboe%40kernel.org
patch subject: [PATCH 3/3] objtool: Add noinstr validation for static branches/calls
config: powerpc-motionpro_defconfig (https://download.01.org/0day-ci/archive/20241125/202411251459.P7KctSbw-lkp@intel.com/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241125/202411251459.P7KctSbw-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411251459.P7KctSbw-lkp@intel.com/

All errors (new ones prefixed by >>):

>> init/main.c:821:1: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
     821 | DEFINE_STATIC_KEY_MAYBE_RO(CONFIG_RANDOMIZE_KSTACK_OFFSET_DEFAULT,
         | ^
   include/linux/jump_label.h:430:2: note: expanded from macro 'DEFINE_STATIC_KEY_MAYBE_RO'
     430 |         __PASTE(_DEFINE_STATIC_KEY_RO_, IS_ENABLED(cfg))(name)
         |         ^
   include/linux/compiler_types.h:84:22: note: expanded from macro '__PASTE'
      84 | #define __PASTE(a,b) ___PASTE(a,b)
         |                      ^
   include/linux/compiler_types.h:83:23: note: expanded from macro '___PASTE'
      83 | #define ___PASTE(a,b) a##b
         |                       ^
   <scratch space>:51:1: note: expanded from here
      51 | _DEFINE_STATIC_KEY_RO_0
         | ^
   include/linux/jump_label.h:428:39: note: expanded from macro '_DEFINE_STATIC_KEY_RO_0'
     428 | #define _DEFINE_STATIC_KEY_RO_0(name)   DEFINE_STATIC_KEY_FALSE_RO(name)
         |                                         ^
   include/linux/jump_label.h:388:2: note: expanded from macro 'DEFINE_STATIC_KEY_FALSE_RO'
     388 |         ANNOTATE_NOINSTR_ALLOWED(name)
         |         ^
>> init/main.c:822:7: error: a parameter list without types is only allowed in a function definition
     822 |                            randomize_kstack_offset);
         |                            ^
   2 errors generated.


vim +/int +821 init/main.c

4e37958d1288ce Steven Rostedt (VMware  2018-03-26  819) 
8cb37a5974a485 Marco Elver             2022-01-31  820  #ifdef CONFIG_RANDOMIZE_KSTACK_OFFSET
39218ff4c625db Kees Cook               2021-04-01 @821  DEFINE_STATIC_KEY_MAYBE_RO(CONFIG_RANDOMIZE_KSTACK_OFFSET_DEFAULT,
39218ff4c625db Kees Cook               2021-04-01 @822  			   randomize_kstack_offset);
39218ff4c625db Kees Cook               2021-04-01  823  DEFINE_PER_CPU(u32, kstack_offset);
39218ff4c625db Kees Cook               2021-04-01  824  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki