linux-kernel - Re: [PATCH 3/3] objtool: Add noinstr validation for static branches/calls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202411251530.5P17DWTE-lkp@intel.com>
Date: Mon, 25 Nov 2024 16:00:47 +0800
From: kernel test robot <lkp@...el.com>
To: Josh Poimboeuf <jpoimboe@...nel.org>,
	Valentin Schneider <vschneid@...hat.com>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
	Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH 3/3] objtool: Add noinstr validation for static
 branches/calls

Hi Josh,

kernel test robot noticed the following build errors:

[auto build test ERROR on linus/master]
[also build test ERROR on v6.12 next-20241125]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Josh-Poimboeuf/jump_label-Add-annotations-for-validating-noinstr-usage/20241125-105905
base:   linus/master
patch link:    https://lore.kernel.org/r/b5746646456eb030673cdb62c23d69ed83c2702a.1732326588.git.jpoimboe%40kernel.org
patch subject: [PATCH 3/3] objtool: Add noinstr validation for static branches/calls
config: m68k-bvme6000_defconfig (https://download.01.org/0day-ci/archive/20241125/202411251530.5P17DWTE-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241125/202411251530.5P17DWTE-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411251530.5P17DWTE-lkp@intel.com/

All error/warnings (new ones prefixed by >>):

   In file included from include/linux/static_key.h:1,
                    from include/linux/alloc_tag.h:15,
                    from include/linux/percpu.h:5,
                    from include/linux/percpu_counter.h:14,
                    from include/linux/mm_types.h:21,
                    from include/linux/mmzone.h:22,
                    from include/linux/gfp.h:7,
                    from include/linux/mm.h:7,
                    from mm/usercopy.c:13:
>> include/linux/jump_label.h:388:9: warning: data definition has no type or storage class
     388 |         ANNOTATE_NOINSTR_ALLOWED(name)
         |         ^~~~~~~~~~~~~~~~~~~~~~~~
   mm/usercopy.c:204:8: note: in expansion of macro 'DEFINE_STATIC_KEY_FALSE_RO'
     204 | static DEFINE_STATIC_KEY_FALSE_RO(bypass_usercopy_checks);
         |        ^~~~~~~~~~~~~~~~~~~~~~~~~~
>> include/linux/jump_label.h:388:9: error: type defaults to 'int' in declaration of 'ANNOTATE_NOINSTR_ALLOWED' [-Wimplicit-int]
     388 |         ANNOTATE_NOINSTR_ALLOWED(name)
         |         ^~~~~~~~~~~~~~~~~~~~~~~~
   mm/usercopy.c:204:8: note: in expansion of macro 'DEFINE_STATIC_KEY_FALSE_RO'
     204 | static DEFINE_STATIC_KEY_FALSE_RO(bypass_usercopy_checks);
         |        ^~~~~~~~~~~~~~~~~~~~~~~~~~
>> include/linux/jump_label.h:371:39: error: parameter names (without types) in function declaration [-Wdeclaration-missing-parameter-type]
     371 | #define STATIC_KEY_FALSE_INIT (struct static_key_false){ .key = STATIC_KEY_INIT_FALSE, }
         |                                       ^~~~~~~~~~~~~~~~
   include/linux/jump_label.h:387:56: note: in expansion of macro 'STATIC_KEY_FALSE_INIT'
     387 |         struct static_key_false name __ro_after_init = STATIC_KEY_FALSE_INIT;   \
         |                                                        ^~~~~~~~~~~~~~~~~~~~~
   mm/usercopy.c:204:8: note: in expansion of macro 'DEFINE_STATIC_KEY_FALSE_RO'
     204 | static DEFINE_STATIC_KEY_FALSE_RO(bypass_usercopy_checks);
         |        ^~~~~~~~~~~~~~~~~~~~~~~~~~


vim +388 include/linux/jump_label.h

   369	
   370	#define STATIC_KEY_TRUE_INIT  (struct static_key_true) { .key = STATIC_KEY_INIT_TRUE,  }
 > 371	#define STATIC_KEY_FALSE_INIT (struct static_key_false){ .key = STATIC_KEY_INIT_FALSE, }
   372	
   373	#define DEFINE_STATIC_KEY_TRUE(name)	\
   374		struct static_key_true name = STATIC_KEY_TRUE_INIT
   375	
   376	#define DEFINE_STATIC_KEY_TRUE_RO(name)						\
   377		struct static_key_true name __ro_after_init = STATIC_KEY_TRUE_INIT;	\
   378		ANNOTATE_NOINSTR_ALLOWED(name)
   379	
   380	#define DECLARE_STATIC_KEY_TRUE(name)	\
   381		extern struct static_key_true name
   382	
   383	#define DEFINE_STATIC_KEY_FALSE(name)	\
   384		struct static_key_false name = STATIC_KEY_FALSE_INIT
   385	
   386	#define DEFINE_STATIC_KEY_FALSE_RO(name)					\
   387		struct static_key_false name __ro_after_init = STATIC_KEY_FALSE_INIT;	\
 > 388		ANNOTATE_NOINSTR_ALLOWED(name)
   389	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki