| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202411251822.MQI8kf80-lkp@intel.com>
Date: Mon, 25 Nov 2024 18:47:00 +0800
From: kernel test robot <lkp@...el.com>
To: Josh Poimboeuf <jpoimboe@...nel.org>,
Valentin Schneider <vschneid@...hat.com>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH 3/3] objtool: Add noinstr validation for static
branches/calls
Hi Josh,
kernel test robot noticed the following build warnings:
[auto build test WARNING on linus/master]
[also build test WARNING on v6.12 next-20241125]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Josh-Poimboeuf/jump_label-Add-annotations-for-validating-noinstr-usage/20241125-105905
base: linus/master
patch link: https://lore.kernel.org/r/b5746646456eb030673cdb62c23d69ed83c2702a.1732326588.git.jpoimboe%40kernel.org
patch subject: [PATCH 3/3] objtool: Add noinstr validation for static branches/calls
config: i386-buildonly-randconfig-001-20241125 (https://download.01.org/0day-ci/archive/20241125/202411251822.MQI8kf80-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241125/202411251822.MQI8kf80-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411251822.MQI8kf80-lkp@intel.com/
All warnings (new ones prefixed by >>):
In file included from include/linux/static_key.h:1,
from arch/x86/include/asm/nospec-branch.h:6,
from arch/x86/include/asm/paravirt_types.h:12,
from arch/x86/include/asm/ptrace.h:175,
from arch/x86/include/asm/math_emu.h:5,
from arch/x86/include/asm/processor.h:13,
from include/linux/sched.h:13,
from include/linux/context_tracking.h:5,
from arch/x86/kernel/kvm.c:12:
include/linux/jump_label.h:388:9: warning: data definition has no type or storage class
388 | ANNOTATE_NOINSTR_ALLOWED(name)
| ^~~~~~~~~~~~~~~~~~~~~~~~
arch/x86/kernel/kvm.c:48:1: note: in expansion of macro 'DEFINE_STATIC_KEY_FALSE_RO'
48 | DEFINE_STATIC_KEY_FALSE_RO(kvm_async_pf_enabled);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/jump_label.h:388:9: error: type defaults to 'int' in declaration of 'ANNOTATE_NOINSTR_ALLOWED' [-Werror=implicit-int]
388 | ANNOTATE_NOINSTR_ALLOWED(name)
| ^~~~~~~~~~~~~~~~~~~~~~~~
arch/x86/kernel/kvm.c:48:1: note: in expansion of macro 'DEFINE_STATIC_KEY_FALSE_RO'
48 | DEFINE_STATIC_KEY_FALSE_RO(kvm_async_pf_enabled);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
>> include/linux/jump_label.h:371:39: warning: parameter names (without types) in function declaration
371 | #define STATIC_KEY_FALSE_INIT (struct static_key_false){ .key = STATIC_KEY_INIT_FALSE, }
| ^~~~~~~~~~~~~~~~
include/linux/jump_label.h:387:56: note: in expansion of macro 'STATIC_KEY_FALSE_INIT'
387 | struct static_key_false name __ro_after_init = STATIC_KEY_FALSE_INIT; \
| ^~~~~~~~~~~~~~~~~~~~~
arch/x86/kernel/kvm.c:48:1: note: in expansion of macro 'DEFINE_STATIC_KEY_FALSE_RO'
48 | DEFINE_STATIC_KEY_FALSE_RO(kvm_async_pf_enabled);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
--
In file included from include/linux/static_key.h:1,
from arch/x86/include/asm/nospec-branch.h:6,
from arch/x86/include/asm/paravirt_types.h:12,
from arch/x86/include/asm/ptrace.h:175,
from arch/x86/include/asm/math_emu.h:5,
from arch/x86/include/asm/processor.h:13,
from include/linux/sched.h:13,
from arch/x86/kernel/tsc.c:5:
include/linux/jump_label.h:388:9: warning: data definition has no type or storage class
388 | ANNOTATE_NOINSTR_ALLOWED(name)
| ^~~~~~~~~~~~~~~~~~~~~~~~
arch/x86/kernel/tsc.c:48:8: note: in expansion of macro 'DEFINE_STATIC_KEY_FALSE_RO'
48 | static DEFINE_STATIC_KEY_FALSE_RO(__use_tsc);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/jump_label.h:388:9: error: type defaults to 'int' in declaration of 'ANNOTATE_NOINSTR_ALLOWED' [-Werror=implicit-int]
388 | ANNOTATE_NOINSTR_ALLOWED(name)
| ^~~~~~~~~~~~~~~~~~~~~~~~
arch/x86/kernel/tsc.c:48:8: note: in expansion of macro 'DEFINE_STATIC_KEY_FALSE_RO'
48 | static DEFINE_STATIC_KEY_FALSE_RO(__use_tsc);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
>> include/linux/jump_label.h:371:39: warning: parameter names (without types) in function declaration
371 | #define STATIC_KEY_FALSE_INIT (struct static_key_false){ .key = STATIC_KEY_INIT_FALSE, }
| ^~~~~~~~~~~~~~~~
include/linux/jump_label.h:387:56: note: in expansion of macro 'STATIC_KEY_FALSE_INIT'
387 | struct static_key_false name __ro_after_init = STATIC_KEY_FALSE_INIT; \
| ^~~~~~~~~~~~~~~~~~~~~
arch/x86/kernel/tsc.c:48:8: note: in expansion of macro 'DEFINE_STATIC_KEY_FALSE_RO'
48 | static DEFINE_STATIC_KEY_FALSE_RO(__use_tsc);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
--
In file included from include/linux/static_key.h:1,
from arch/x86/include/asm/nospec-branch.h:6,
from arch/x86/include/asm/irqflags.h:9,
from include/linux/irqflags.h:18,
from include/linux/spinlock.h:59,
from include/linux/mmzone.h:8,
from include/linux/gfp.h:7,
from include/linux/mm.h:7,
from include/linux/memblock.h:12,
from arch/x86/kernel/cpu/common.c:5:
include/linux/jump_label.h:388:9: warning: data definition has no type or storage class
388 | ANNOTATE_NOINSTR_ALLOWED(name)
| ^~~~~~~~~~~~~~~~~~~~~~~~
arch/x86/kernel/cpu/common.c:404:8: note: in expansion of macro 'DEFINE_STATIC_KEY_FALSE_RO'
404 | static DEFINE_STATIC_KEY_FALSE_RO(cr_pinning);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/jump_label.h:388:9: error: type defaults to 'int' in declaration of 'ANNOTATE_NOINSTR_ALLOWED' [-Werror=implicit-int]
388 | ANNOTATE_NOINSTR_ALLOWED(name)
| ^~~~~~~~~~~~~~~~~~~~~~~~
arch/x86/kernel/cpu/common.c:404:8: note: in expansion of macro 'DEFINE_STATIC_KEY_FALSE_RO'
404 | static DEFINE_STATIC_KEY_FALSE_RO(cr_pinning);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
>> include/linux/jump_label.h:371:39: warning: parameter names (without types) in function declaration
371 | #define STATIC_KEY_FALSE_INIT (struct static_key_false){ .key = STATIC_KEY_INIT_FALSE, }
| ^~~~~~~~~~~~~~~~
include/linux/jump_label.h:387:56: note: in expansion of macro 'STATIC_KEY_FALSE_INIT'
387 | struct static_key_false name __ro_after_init = STATIC_KEY_FALSE_INIT; \
| ^~~~~~~~~~~~~~~~~~~~~
arch/x86/kernel/cpu/common.c:404:8: note: in expansion of macro 'DEFINE_STATIC_KEY_FALSE_RO'
404 | static DEFINE_STATIC_KEY_FALSE_RO(cr_pinning);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +371 include/linux/jump_label.h
11276d5306b8e5 Peter Zijlstra 2015-07-24 369
11276d5306b8e5 Peter Zijlstra 2015-07-24 370 #define STATIC_KEY_TRUE_INIT (struct static_key_true) { .key = STATIC_KEY_INIT_TRUE, }
11276d5306b8e5 Peter Zijlstra 2015-07-24 @371 #define STATIC_KEY_FALSE_INIT (struct static_key_false){ .key = STATIC_KEY_INIT_FALSE, }
11276d5306b8e5 Peter Zijlstra 2015-07-24 372
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists