linux-kernel - Re: [PATCH 05/11] x86/cpu: Refresh DCA leaf reading code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6590827b-d4cc-45eb-9608-6be5d354eb57@intel.com>
Date: Mon, 25 Nov 2024 19:55:50 -0800
From: Dave Hansen <dave.hansen@...el.com>
To: Zhao Liu <zhao1.liu@...el.com>, Dave Hansen <dave.hansen@...ux.intel.com>
Cc: linux-kernel@...r.kernel.org, x86@...nel.org, tglx@...utronix.de,
 bp@...en8.de, rafael@...nel.org, lenb@...nel.org, dave.jiang@...el.com,
 irenic.rajneesh@...il.com, david.e.box@...el.com
Subject: Re: [PATCH 05/11] x86/cpu: Refresh DCA leaf reading code

On 11/25/24 20:11, Zhao Liu wrote:
>> -#define CPUID_MWAIT_LEAF		5
>> +#define CPUID_MWAIT_LEAF	0x5
> Nit, this change can be merged into patch 1?

Except that it doesn't make any sense in patch 1. At least in this patch
you can tell that the change is being made for consistency. If it's in
patch 1, it looks like a random, arbitrary change.