linux-kernel - RE: [PATCH 1/3] dt-bindings: memory-controllers: Add support for Versal NET EDAC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <SA1PR12MB89479EFB910D009F2F3A7641812F2@SA1PR12MB8947.namprd12.prod.outlook.com>
Date: Tue, 26 Nov 2024 06:57:22 +0000
From: "Datta, Shubhrajyoti" <shubhrajyoti.datta@....com>
To: Krzysztof Kozlowski <krzk@...nel.org>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>, "git (AMD-Xilinx)"
	<git@....com>, "robh@...nel.org" <robh@...nel.org>, "conor+dt@...nel.org"
	<conor+dt@...nel.org>, "bp@...en8.de" <bp@...en8.de>, "tony.luck@...el.com"
	<tony.luck@...el.com>, "james.morse@....com" <james.morse@....com>,
	"mchehab@...nel.org" <mchehab@...nel.org>, "rric@...nel.org"
	<rric@...nel.org>
Subject: RE: [PATCH 1/3] dt-bindings: memory-controllers: Add support for
 Versal NET EDAC

[AMD Official Use Only - AMD Internal Distribution Only]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@...nel.org>
> Sent: Saturday, November 23, 2024 10:15 PM
> To: Datta, Shubhrajyoti <shubhrajyoti.datta@....com>
> Cc: linux-kernel@...r.kernel.org; devicetree@...r.kernel.org; linux-
> edac@...r.kernel.org; git (AMD-Xilinx) <git@....com>; krzk@...nel.or;
> robh@...nel.org; conor+dt@...nel.org; bp@...en8.de; tony.luck@...el.com;
> james.morse@....com; mchehab@...nel.org; rric@...nel.org
> Subject: Re: [PATCH 1/3] dt-bindings: memory-controllers: Add support for Versal
> NET EDAC
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> On Fri, Nov 22, 2024 at 03:36:23PM +0530, Shubhrajyoti Datta wrote:
> > Add device tree bindings for AMD Versal NET EDAC for DDR controller.
> >
> > Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@....com>
> > ---
> >
>
> Use tools to create cc-list, like b4 or:
> https://github.com/krzk/tools/blob/master/linux/.bash_aliases_linux#L92
> so you won't make a typo in my email.
>
> >  .../amd,versalnet-edac.yaml                   | 56 +++++++++++++++++++
> >  1 file changed, 56 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/memory-controllers/amd,versalnet-eda
> > c.yaml
> >
> > diff --git
> > a/Documentation/devicetree/bindings/memory-controllers/amd,versalnet-e
> > dac.yaml
> > b/Documentation/devicetree/bindings/memory-controllers/amd,versalnet-e
> > dac.yaml
> > new file mode 100644
> > index 000000000000..22a4669c46b6
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/memory-controllers/amd,versaln
> > +++ et-edac.yaml
> > @@ -0,0 +1,56 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) %YAML 1.2
> > +---
> > +$id:
> > +http://devicetree.org/schemas/memory-controllers/amd,versalnet-edac.y
> > +aml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: AMD Versal NET EDAC
>
> s/EDAC/Memory Controller
> or something similar, I guess.

Will do

>
> > +
> > +maintainers:
> > +  - Shubhrajyoti Datta <shubhrajyoti.datta@....com>
> > +
> > +description:
> > +  The integrated DDR Memory Controllers (DDRMCs) support both DDR4
> > +and LPDDR4/
> > +  4X memory interfaces. Versal NET DDR memory controller has an
> > +optional ECC support
> > +  which correct single bit ECC errors and detect double bit ECC errors.
> > +  It also has support for reporting other errors like MMCM
> > +(Mixed-Mode Clock
> > +  Manager) errors and General software errors.
> > +
> > +properties:
> > +  compatible:
> > +    const: amd,versalnet-edac
>
> Why using different name than all others? Keep consistent stuff for your SoCs.
>
> Also, s/edac/memory-controller/, depending what this stuff really is.

Will do
>
> > +
> > +  amd,dwidth:
> > +    description:
> > +      DDR memory controller device width.
>
> Use existing properties.
>
>
> > +    enum: [16, 32]
> > +    $ref: /schemas/types.yaml#/definitions/uint32
> > +
> > +  amd,num-chans:
> > +    description:
> > +      Number of channels.
>
> Use existing properties, e.g. some of the DDR schemas describing memory.
> Look how other bindings describe actual chips.
>
> > +    enum: [1, 2]
> > +    $ref: /schemas/types.yaml#/definitions/uint32
> > +
> > +  amd,num-rank:
> > +    description:
> > +      Number of rank.
> > +    enum: [1, 2, 4]
> > +    $ref: /schemas/types.yaml#/definitions/uint32
> > +
> > +required:
> > +  - compatible
>
> Eh, no resources? How do you talk with the hardware? This looks way too Linuxy...

The address space is secure, making it inaccessible to Linux. In this setup, the secure firmware (NMC)
 communicates the necessary information to Linux through RPMsg.
>
> Best regards,
> Krzysztof