linux-kernel - Re: [PATCH 1/3] dt-bindings: memory-controllers: Add support for Versal NET EDAC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fab9ebcd-535c-49c0-b356-ca6a4886049b@kernel.org>
Date: Tue, 26 Nov 2024 08:07:26 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: "Datta, Shubhrajyoti" <shubhrajyoti.datta@....com>
Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
 "git (AMD-Xilinx)" <git@....com>, "robh@...nel.org" <robh@...nel.org>,
 "conor+dt@...nel.org" <conor+dt@...nel.org>, "bp@...en8.de" <bp@...en8.de>,
 "tony.luck@...el.com" <tony.luck@...el.com>,
 "james.morse@....com" <james.morse@....com>,
 "mchehab@...nel.org" <mchehab@...nel.org>, "rric@...nel.org"
 <rric@...nel.org>
Subject: Re: [PATCH 1/3] dt-bindings: memory-controllers: Add support for
 Versal NET EDAC

On 26/11/2024 07:57, Datta, Shubhrajyoti wrote:
> [AMD Official Use Only - AMD Internal Distribution Only]

What is this? Why would we bother? How does it affect me?

Please remove all corporate boilerplate.


...

>>> +
>>> +required:
>>> +  - compatible
>>
>> Eh, no resources? How do you talk with the hardware? This looks way too Linuxy...
> 
> The address space is secure, making it inaccessible to Linux. In this setup, the secure firmware (NMC)
>  communicates the necessary information to Linux through RPMsg.


Don't you need to acquire a reference to the rpmsg interface? Don't you
need to encode the device dependency? All this is achieved with phandles
and proper driver support.

Best regards,
Krzysztof