linux-kernel - Re: [PATCH 1/3] dt-bindings: memory-controllers: Add support for Versal NET EDAC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKfKVtEREOLxK=SF5F-3MkpxyS+HcSTOH-pML2b4x2pCV13XMA@mail.gmail.com>
Date: Mon, 23 Dec 2024 15:28:37 +0530
From: Shubhrajyoti Datta <shubhrajyoti.datta@...il.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Shubhrajyoti Datta <shubhrajyoti.datta@....com>, linux-kernel@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-edac@...r.kernel.org, git@....com, 
	krzk@...nel.or, robh@...nel.org, conor+dt@...nel.org, bp@...en8.de, 
	tony.luck@...el.com, james.morse@....com, mchehab@...nel.org, rric@...nel.org
Subject: Re: [PATCH 1/3] dt-bindings: memory-controllers: Add support for
 Versal NET EDAC

Hi Krzysztof,

On Sat, Nov 23, 2024 at 10:14 PM Krzysztof Kozlowski <krzk@...nel.org> wrote:
>
> On Fri, Nov 22, 2024 at 03:36:23PM +0530, Shubhrajyoti Datta wrote:
> > Add device tree bindings for AMD Versal NET EDAC for DDR controller.
> >
> > Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@....com>
> > ---
> >
>
..
> > +
> > +  amd,dwidth:
> > +    description:
> > +      DDR memory controller device width.
>
> Use existing properties.
I am not finding any existing properties could you help me with some pointers.

>
>
> > +    enum: [16, 32]
> > +    $ref: /schemas/types.yaml#/definitions/uint32
> > +
> > +  amd,num-chans:
> > +    description:
> > +      Number of channels.
>
> Use existing properties, e.g. some of the DDR schemas describing memory.
> Look how other bindings describe actual chips.

could you share any example. My search didnt return anything
>
> > +    enum: [1, 2]
> > +    $ref: /schemas/types.yaml#/definitions/uint32
> > +
> > +  amd,num-rank:
> > +    description:
> > +      Number of rank.
> > +    enum: [1, 2, 4]
> > +    $ref: /schemas/types.yaml#/definitions/uint32
> > +
> > +required:
> > +  - compatible
>
> Eh, no resources? How do you talk with the hardware? This looks way too
> Linuxy...

will add a remote proc property

 amd,rproc:
    $ref: /schemas/types.yaml#/definitions/phandle
    description:
      phandle to the remoteproc_r5 rproc node using which APU interacts
      with remote processor.

  memory-controller {
...
       amd,rproc = <&remoteproc_r5>;
     };
>
> Best regards,
> Krzysztof
>
>