linux-kernel - Re: [PATCH] gpio: gpio-pca953x: do not enable regmap cache when there is no regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMRc=McQ8J_x40YEUQSN7prGovHoTqvoePq-HznUdpjYqO_cCw@mail.gmail.com>
Date: Wed, 27 Nov 2024 14:05:12 +0100
From: Bartosz Golaszewski <brgl@...ev.pl>
To: haibo.chen@....com
Cc: linus.walleij@...aro.org, lgirdwood@...il.com, broonie@...nel.org, 
	linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org, imx@...ts.linux.dev, 
	marek.vasut@...il.com
Subject: Re: [PATCH] gpio: gpio-pca953x: do not enable regmap cache when there
 is no regulator

On Wed, Nov 27, 2024 at 8:15 AM <haibo.chen@....com> wrote:
>
> From: Haibo Chen <haibo.chen@....com>
>
> Regmap cache mechanism is enabled in default. Thus, IO expander wouldn't
> handle GPIO set really before resuming back.
>
> But there are cases need to toggle gpio in NO_IRQ stage.
> e.g. To align with PCIe specification, PERST# signal connected on the IO
> expander must be toggled during PCIe RC's NO_IRQ_RESUME.
>
> Do not enable the regmap cache when IO expander doesn't have the regulator
> during system PM. That means the power of IO expander would be kept on,
> and the GPIOs of the IO expander can be toggled really during system PM.
>
> Signed-off-by: Haibo Chen <haibo.chen@....com>
> ---

The commit title should be: "gpio: pca953x: ..."

This description makes it sound like a fix, can you add a Fixes: tag?

Bart