linux-kernel - RE: [PATCH] gpio: gpio-pca953x: do not enable regmap cache when there is no regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <DU0PR04MB94961DC24122BFAB4B58A03F90292@DU0PR04MB9496.eurprd04.prod.outlook.com>
Date: Thu, 28 Nov 2024 01:31:08 +0000
From: Bough Chen <haibo.chen@....com>
To: Bartosz Golaszewski <brgl@...ev.pl>
CC: "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
	"lgirdwood@...il.com" <lgirdwood@...il.com>, "broonie@...nel.org"
	<broonie@...nel.org>, "linux-gpio@...r.kernel.org"
	<linux-gpio@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "imx@...ts.linux.dev" <imx@...ts.linux.dev>,
	"marek.vasut@...il.com" <marek.vasut@...il.com>
Subject: RE: [PATCH] gpio: gpio-pca953x: do not enable regmap cache when there
 is no regulator

> -----Original Message-----
> From: Bartosz Golaszewski <brgl@...ev.pl>
> Sent: 2024年11月27日 21:05
> To: Bough Chen <haibo.chen@....com>
> Cc: linus.walleij@...aro.org; lgirdwood@...il.com; broonie@...nel.org;
> linux-gpio@...r.kernel.org; linux-kernel@...r.kernel.org; imx@...ts.linux.dev;
> marek.vasut@...il.com
> Subject: Re: [PATCH] gpio: gpio-pca953x: do not enable regmap cache when
> there is no regulator
> 
> On Wed, Nov 27, 2024 at 8:15 AM <haibo.chen@....com> wrote:
> >
> > From: Haibo Chen <haibo.chen@....com>
> >
> > Regmap cache mechanism is enabled in default. Thus, IO expander
> > wouldn't handle GPIO set really before resuming back.
> >
> > But there are cases need to toggle gpio in NO_IRQ stage.
> > e.g. To align with PCIe specification, PERST# signal connected on the
> > IO expander must be toggled during PCIe RC's NO_IRQ_RESUME.
> >
> > Do not enable the regmap cache when IO expander doesn't have the
> > regulator during system PM. That means the power of IO expander would
> > be kept on, and the GPIOs of the IO expander can be toggled really during
> system PM.
> >
> > Signed-off-by: Haibo Chen <haibo.chen@....com>
> > ---
> 
> The commit title should be: "gpio: pca953x: ..."
> 
> This description makes it sound like a fix, can you add a Fixes: tag?

Okay, will add in next version

Regards
Haibo Chen
> 
> Bart