linux-kernel - Re: [PATCH] ARM: imx_*_defconfig: Fix i.MX pinctrl enablement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOMZO5CbgmGpJvurf0Ctomj5dDOt=dC5X8XvwaqsM9Ce_uXhUQ@mail.gmail.com>
Date: Wed, 27 Nov 2024 16:36:12 -0300
From: Fabio Estevam <festevam@...il.com>
To: Mark Brown <broonie@...nel.org>
Cc: Russell King <linux@...linux.org.uk>, Shawn Guo <shawnguo@...nel.org>, 
	Sascha Hauer <s.hauer@...gutronix.de>, Pengutronix Kernel Team <kernel@...gutronix.de>, 
	Linus Walleij <linus.walleij@...aro.org>, Esben Haabendal <esben@...nix.com>, 
	linux-arm-kernel@...ts.infradead.org, soc@...ts.linux.dev, 
	imx@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: imx_*_defconfig: Fix i.MX pinctrl enablement

On Wed, Nov 27, 2024 at 4:25 PM Mark Brown <broonie@...nel.org> wrote:
>
> When the i.MX pinctrl drivers were made user controllable by 17d210018914
> ("ARM: imx: Allow user to disable pinctrl") the select of pinctrl by the
> arch code was removed. This change means that for the i.MX specific
> defconfigs nothing enables the base PINCTRL Kconfig and things that depend
> on it (eg, audio on the i.MX6 UDOO boards) stop working. Explicitly enable
> PINCTRL in these configs to restore functionality with them.
>
> Fixes: 17d210018914 ("ARM: imx: Allow user to disable pinctrl")
> Signed-off-by: Mark Brown <broonie@...nel.org>

I submitted the same fix:

https://lore.kernel.org/imx/d718ddd2-d473-4455-b21a-15024e46787c@roeck-us.net/T/#mc71dc21d99e0b013c5ce46c0d90940fd8806ae9a

but as Guenter pointed out, there are other defconfigs that select
ARCH_MXC, so this change is incomplete.

It will also cause regressions for people that have their own
defconfigs (where PINCTRL is not selected).

Then I came up with a v2 that simply re-select PINCTRL as a minimal
fix for the regressions:

https://lore.kernel.org/linux-arm-kernel/f65d65b3-b60c-4c5c-a002-81370821ee1f@app.fastmail.com/T/#u