linux-kernel - Re: [PATCH v3 3/7] efi/cper, cxl: Remove cper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <97ed072e-e32c-201e-69a1-1a43fc98ac4c@amd.com>
Date: Wed, 27 Nov 2024 11:36:29 -0800
From: Smita Koralahalli <Smita.KoralahalliChannabasappa@....com>
To: Jonathan Cameron <Jonathan.Cameron@...wei.com>
Cc: linux-efi@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-cxl@...r.kernel.org, Ard Biesheuvel <ardb@...nel.org>,
 Alison Schofield <alison.schofield@...el.com>,
 Vishal Verma <vishal.l.verma@...el.com>, Ira Weiny <ira.weiny@...el.com>,
 Dan Williams <dan.j.williams@...el.com>,
 Yazen Ghannam <yazen.ghannam@....com>, Terry Bowman <terry.bowman@....com>
Subject: Re: [PATCH v3 3/7] efi/cper, cxl: Remove cper_cxl.h

On 11/26/2024 7:51 AM, Jonathan Cameron wrote:
> On Tue, 19 Nov 2024 00:39:11 +0000
> Smita Koralahalli <Smita.KoralahalliChannabasappa@....com> wrote:
> 
>> Move the declaration of cxl_cper_print_prot_err() to include/linux/cper.h
>> to avoid maintaining a separate header file just for this function
>> declaration. Remove drivers/firmware/efi/cper_cxl.h as its contents have
>> been reorganized.
>>
>> Eliminate its corresponding #include directives from source files that
>> previously included it, since the header file has been removed.
> 
> You lost me on this one.  Looks like only place these existed was the now
> empty header?  I'd not mention that as it's just bit confusing.

Yes. I will remove this sentence.

Thanks
Smita
> 
> 
>>
>> No functional changes.
>>
>> Signed-off-by: Smita Koralahalli <Smita.KoralahalliChannabasappa@....com>
>> diff --git a/drivers/firmware/efi/cper_cxl.h b/drivers/firmware/efi/cper_cxl.h
>> deleted file mode 100644
>> index 5ce1401ee17a..000000000000
>> --- a/drivers/firmware/efi/cper_cxl.h
>> +++ /dev/null
>> @@ -1,16 +0,0 @@
>> -/* SPDX-License-Identifier: GPL-2.0-only */
>> -/*
>> - * UEFI Common Platform Error Record (CPER) support for CXL Section.
>> - *
>> - * Copyright (C) 2022 Advanced Micro Devices, Inc.
>> - *
>> - * Author: Smita Koralahalli <Smita.KoralahalliChannabasappa@....com>
>> - */
>> -
>> -#ifndef LINUX_CPER_CXL_H
>> -#define LINUX_CPER_CXL_H
>> -
>> -void cxl_cper_print_prot_err(const char *pfx,
>> -			     const struct cxl_cper_sec_prot_err *prot_err);
>> -
>> -#endif //__CPER_CXL_