linux-kernel - Re: [PATCH v2] locking/lockdep: Enforce PROVE_RAW_LOCK_NESTING only if ARCH_SUPPORTS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6fc258b5-37b8-4739-8f6f-317f06fc6eab@roeck-us.net>
Date: Wed, 27 Nov 2024 19:19:08 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Waiman Long <longman@...hat.com>, Peter Zijlstra <peterz@...radead.org>,
 Ingo Molnar <mingo@...hat.com>, Will Deacon <will.deacon@....com>,
 Boqun Feng <boqun.feng@...il.com>
Cc: linux-kernel@...r.kernel.org,
 Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Subject: Re: [PATCH v2] locking/lockdep: Enforce PROVE_RAW_LOCK_NESTING only
 if ARCH_SUPPORTS_RT

On 11/27/24 18:00, Waiman Long wrote:
> Relax the rule to set PROVE_RAW_LOCK_NESTING by default only for arches
> that supports PREEMPT_RT.  For arches that do not support PREEMPT_RT,
> they will not be forced to address unimportant raw lock nesting issues
> when they want to enable PROVE_LOCKING.  They do have the option
> to enable it to look for these raw locking nesting problems if they
> choose to.
> 
> Suggested-by: Guenter Roeck <linux@...ck-us.net>
> Signed-off-by: Waiman Long <longman@...hat.com>

Tested-by: Guenter Roeck <linux@...ck-us.net>

> ---
>   lib/Kconfig.debug | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index 1e37c62e8595..942b4cb138bd 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -1397,9 +1397,9 @@ config PROVE_LOCKING
>   	 For more details, see Documentation/locking/lockdep-design.rst.
>   
>   config PROVE_RAW_LOCK_NESTING
> -	bool
> +	bool "Enable raw_spinlock - spinlock nesting checks" if !ARCH_SUPPORTS_RT
>   	depends on PROVE_LOCKING
> -	default y
> +	default y if ARCH_SUPPORTS_RT
>   	help
>   	 Enable the raw_spinlock vs. spinlock nesting checks which ensure
>   	 that the lock nesting rules for PREEMPT_RT enabled kernels are