linux-kernel - Re: [PATCH v6 4/5] arm64: dts: qcom: sc7280: Add support for camss

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <ffca115a-4c7e-4583-9da5-225587c41043@kernel.org>
Date: Thu, 28 Nov 2024 08:04:59 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Vikram Sharma <quic_vikramsa@...cinc.com>, rfoss@...nel.org,
 todor.too@...il.com, bryan.odonoghue@...aro.org, mchehab@...nel.org,
 robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
 akapatra@...cinc.com, hariramp@...cinc.com, andersson@...nel.org,
 konradybcio@...nel.org, hverkuil-cisco@...all.nl,
 cros-qcom-dts-watchers@...omium.org, catalin.marinas@....com, will@...nel.org
Cc: linux-arm-kernel@...ts.infradead.org, linux-media@...r.kernel.org,
 linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, kernel@...cinc.com
Subject: Re: [PATCH v6 4/5] arm64: dts: qcom: sc7280: Add support for camss

On 27/11/2024 21:33, Vikram Sharma wrote:
> Hi Krzysztof,
> 
> Thanks for your comments.
> 
> I used below tools on my changes and here are the results.
> 
> 1) checkpatch.pl :
> /scripts/checkpatch.pl 
> patches_camss_v6/v6-0001-media-dt-bindings-Add-qcom-sc7280-camss.patch
> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> #18:
> new file mode 100644
> total: 0 errors, 1 warnings, 415 lines checked
> NOTE: For some of the reported defects, checkpatch may be able to
>        mechanically convert to the typical style using --fix or 
> --fix-inplace.
> patches_camss_v6/v6-0001-media-dt-bindings-Add-qcom-sc7280-camss.patch 
> has style problems, please review.
> NOTE: If any of the errors are false positives, please report
>        them to the maintainer, see CHECKPATCH in MAINTAINERS.
> 
> For maintainer related warnings I cross-checked that MAINTAINERS are 
> already updated properly.
> Patch 2,3, 4 had zero errors and warnings.
> Patch 5 have same Maintainer Warnings.
> 
> For DT validation i am using these tools as per below link:
> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
> 
> 2) dt_binding_check :
> touch Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml
> result:
> *make DT_CHECKER_FLAGS=-m DT_SCHEMA_FILES=media/qcom,sc7280-camss.yaml 
> dt_binding_check*
>    SCHEMA  Documentation/devicetree/bindings/processed-schema.json
> */local/mnt/workspace/k2c_build/vikram/v6_submit/linux-next/Documentation/devicetree/bindings/net/snps,dwmac.yaml: 
> mac-mode: missing type definition -> Not related to this change.*
>    CHKDT   ./Documentation/devicetree/bindings
>    LINT    ./Documentation/devicetree/bindings
>    DTEX 
> Documentation/devicetree/bindings/media/qcom,sc7280-camss.example.dts
>    DTC [C] 
> Documentation/devicetree/bindings/media/qcom,sc7280-camss.example.dtb
> 
> 3) CHECK_DTBS:
> result:
> touch arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-vision-mezzanine.dtso
> touch  arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> 
> *make CHECK_DTBS=y qcom/qcs6490-rb3gen2-vision-mezzanine.dtb*
>    DTC [C] arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dtb
>    DTC arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-vision-mezzanine.dtbo
>    OVL [C] arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-vision-mezzanine.dtb
> 
> To confirm if my tools are working properly. I tried inducing errors too.
> Till this point there were no issues reported by tools.
> 
> As per your comment I have added 'W=1' which gave 1 warning.
> arch/arm64/boot/dts/qcom/sc7280.dtsi:4429.24-4597.5: Warning 
> (simple_bus_reg): /soc@...amss@...f000: simple-bus unit address format 
> error, expected "acb3000"

This is the warning which we are not suppose to remind you more than once.


> 
> Till this point I missed to add 'W=1' as I was following the blog.  I 
> will address that and submit v7

Blog is just short instruction, you should refer to SoC maintainer
profiles in Linux kernel.



Best regards,
Krzysztof