linux-kernel - Re: [PATCH can-next v2] dt-bindings: can: tcan4x5x: add missing required clock-names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bfc49b65-4d14-4dd1-8dff-e200989a1805@kernel.org>
Date: Thu, 28 Nov 2024 09:09:03 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Sean Nyekjaer <sean@...nix.com>
Cc: Marc Kleine-Budde <mkl@...gutronix.de>,
 Vincent Mailhol <mailhol.vincent@...adoo.fr>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, linux-can@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH can-next v2] dt-bindings: can: tcan4x5x: add missing
 required clock-names

On 28/11/2024 08:49, Sean Nyekjaer wrote:
> Hi Krzysztof,
> 
> On Thu, Nov 28, 2024 at 08:31:41AM +0100, Krzysztof Kozlowski wrote:
>> On 28/11/2024 08:09, Sean Nyekjaer wrote:
>>> tcan4x5x requires an external clock called cclk, add it here.
>>
>> Nothing improved. Device already has this clock, so your rationale is
>> not correct.
> 
> Please explain, yes the device has this clock, but not the name. The
> driver depends on the name.

You say that the device - tcan4x5x - requires an external clock. This is
already satisfied.

> 
>>
>> Also, offending patch is not in the next for some reason, so it should
>> be squashed there. Conversion which leads to incorrect binding is not a
>> correct conversion.
> 
> "offending patch":
> https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git/commit/?h=testing&id=77400284f54b9a1f6b6127c08cb935fc05e5c3d2
> 
> "dt-bindings: can: convert tcan4x5x.txt to DT schema" did the
> conversion no more or less.
> The original txt file fails to mention the clock required,
> therefore IMHO this patch should be as a seperate patch :)

Stop repeating the same as last time.

No, I said it already multiple times in multiple threads, including
guideline I gave some time ago:
https://social.kernel.org/notice/Ai9hYRUKo8suzX3zNY

You conversion is supposed to be complete and pass checks on existing
DTS, which also implies matching driver.

Best regards,
Krzysztof