linux-kernel - Re: [PATCH v4 1/2] dt-bindings: power: supply: Add STC3117 Fuel Gauge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <MA0P287MB11788D277E79E03B6C7E4126F2292@MA0P287MB1178.INDP287.PROD.OUTLOOK.COM>
Date: Thu, 28 Nov 2024 09:22:38 +0000
From: Bhavin Sharma <bhavin.sharma@...iconsignals.io>
To: Krzysztof Kozlowski <krzk@...nel.org>, "sre@...nel.org" <sre@...nel.org>,
	"krzk+dt@...nel.org" <krzk+dt@...nel.org>, "robh@...nel.org"
	<robh@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>
CC: Hardevsinh Palaniya <hardevsinh.palaniya@...iconsignals.io>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 1/2] dt-bindings: power: supply: Add STC3117 Fuel Gauge

Hi Krzysztof,

>>> +  reg:
>>> +    maxItems: 1
>>
>> I asked you some questions on v2, then on v3 and no responses.
>>
>> You implemented some changes but still did not answer my question. I am
>> not going to ask again, obviously expecting different result on the same
>> makes little sense.
>>
>> No ack from me.
>>
>
> You responded privately - I am not going to do any talks under NDA. I
> also do not provide some sort of personal support service. Keep *ALL*
> discussions public.

My apologies, that was unintentional.

> Explaining what you asked:
>
> Some of these are from monitored-battery. Sense resistor should be
> separate property. But different question is about missing resources,
> like supplies (VCC) and interrupts. Just look at datasheet.

since battery itself serves as the power supply for fuel gauge no additional supplies are required. 

Regarding interrupts yes, datasheet specifies an alarm pin that signals low State of Charge or
Voltage conditions. However, I haven’t incorporated interrupts in the driver to handle this. Should I
list the alarm pin as a resource in the device tree (or relevant configuration) even if it’s not 
implemented in the driver yet?

Best Regards,
Bhavin