linux-kernel - Re: [PATCH v4 1/2] dt-bindings: power: supply: Add STC3117 Fuel Gauge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3b0bafb5-602b-4d3e-a944-b290f9d011c7@kernel.org>
Date: Thu, 28 Nov 2024 11:08:02 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Bhavin Sharma <bhavin.sharma@...iconsignals.io>,
 "sre@...nel.org" <sre@...nel.org>, "krzk+dt@...nel.org"
 <krzk+dt@...nel.org>, "robh@...nel.org" <robh@...nel.org>,
 "conor+dt@...nel.org" <conor+dt@...nel.org>
Cc: Hardevsinh Palaniya <hardevsinh.palaniya@...iconsignals.io>,
 "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 1/2] dt-bindings: power: supply: Add STC3117 Fuel Gauge

On 28/11/2024 10:22, Bhavin Sharma wrote:
> 
>> Explaining what you asked:
>>
>> Some of these are from monitored-battery. Sense resistor should be
>> separate property. But different question is about missing resources,
>> like supplies (VCC) and interrupts. Just look at datasheet.
> 
> since battery itself serves as the power supply for fuel gauge no additional supplies are required. 
> 
> Regarding interrupts yes, datasheet specifies an alarm pin that signals low State of Charge or
> Voltage conditions. However, I haven’t incorporated interrupts in the driver to handle this. Should I
> list the alarm pin as a resource in the device tree (or relevant configuration) even if it’s not 
> implemented in the driver yet?

Yes, bindings should be complete.
Best regards,
Krzysztof