linux-kernel - Re: [PATCH v4 2/3] clk: qcom: common: Add support for power-domain attachment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4997c6d8-fa9f-48e9-bb5a-f88946059462@linaro.org>
Date: Thu, 28 Nov 2024 15:07:31 +0200
From: Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>
To: Bryan O'Donoghue <pure.logic@...us-software.ie>,
 Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
 Bjorn Andersson <andersson@...nel.org>,
 Michael Turquette <mturquette@...libre.com>, Stephen Boyd
 <sboyd@...nel.org>, Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Cc: linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 2/3] clk: qcom: common: Add support for power-domain
 attachment

On 11/28/24 14:16, Bryan O'Donoghue wrote:
> On 28/11/2024 12:09, Vladimir Zapolskiy wrote:
>> Please simplify this change, please do not ignore patch reviews, if you
>> find it possible.
>>
>> https://lore.kernel.org/all/8a33c0ff-0c6d-4995-
>> b239-023d2a2c2af5@...aro.org/
> 
> You want this inlined ?

Yes, please. A simpler version should be preferred, by any metrics 3 lines
of code are better than 20 lines of code plus a new added function.

Thank you for understanding.

--
Best wishes,
Vladimir