linux-kernel - Re: [PATCH v9 1/6] misc: Add support for LAN966x PCI device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d1eec09a-23ca-44de-a4e5-5f625a1ec73b@kernel.org>
Date: Fri, 29 Nov 2024 09:22:35 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Herve Codina <herve.codina@...tlin.com>, Michal Kubecek <mkubecek@...e.cz>
Cc: Geert Uytterhoeven <geert@...ux-m68k.org>,
 Andy Shevchenko <andy.shevchenko@...il.com>, Simon Horman
 <horms@...nel.org>, Lee Jones <lee@...nel.org>, Arnd Bergmann
 <arnd@...db.de>, Derek Kiernan <derek.kiernan@....com>,
 Dragan Cvetic <dragan.cvetic@....com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Bjorn Helgaas <bhelgaas@...gle.com>, Philipp Zabel <p.zabel@...gutronix.de>,
 Lars Povlsen <lars.povlsen@...rochip.com>,
 Steen Hegelund <Steen.Hegelund@...rochip.com>,
 Daniel Machon <daniel.machon@...rochip.com>, UNGLinuxDriver@...rochip.com,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Saravana Kannan <saravanak@...gle.com>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Horatiu Vultur <horatiu.vultur@...rochip.com>, Andrew Lunn <andrew@...n.ch>,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 netdev@...r.kernel.org, linux-pci@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org,
 Allan Nielsen <allan.nielsen@...rochip.com>,
 Luca Ceresoli <luca.ceresoli@...tlin.com>,
 Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH v9 1/6] misc: Add support for LAN966x PCI device

On 29/11/2024 09:10, Herve Codina wrote:
>>> +config MCHP_LAN966X_PCI
>>> +	tristate "Microchip LAN966x PCIe Support"
>>> +	depends on PCI
>>> +	select OF
>>> +	select OF_OVERLAY  
>>
>> Are these "select" statements what we want? When configuring current
>> mainline snapshot, I accidentally enabled this driver and ended up
>> flooded with an enormous amount of new config options, most of which
>> didn't make much sense on x86_64. It took quite long to investigate why.
>>
>> Couldn't we rather use
>>
>> 	depends on PCI && OF && OF_OVERLAY
>>
>> like other drivers?
>>
> 
> I don't have a strong opinion on this 'select' vs 'depends on' for those
> symbols.

You should not select user-visible symbols, with exception of arch
stuff. This is not arch, so you should use dependencies.

Best regards,
Krzysztof