[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <5b6cf8f9-fdaf-4719-b1b2-f4745c671263@kernel.org>
Date: Fri, 29 Nov 2024 14:58:17 +0200
From: Roger Quadros <rogerq@...nel.org>
To: Meghana Malladi <m-malladi@...com>, lokeshvutla@...com, vigneshr@...com,
javier.carrasco.cruz@...il.com, diogo.ivo@...mens.com,
jacob.e.keller@...el.com, horms@...nel.org, pabeni@...hat.com,
kuba@...nel.org, edumazet@...gle.com, davem@...emloft.net,
andrew+netdev@...n.ch
Cc: linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, srk@...com, danishanwar@...com
Subject: Re: [PATCH net v2 2/2] net: ti: icssg-prueth: Fix clearing of
IEP_CMP_CFG registers during iep_init
On 28/11/2024 14:29, Meghana Malladi wrote:
> When ICSSG interfaces are brought down and brought up again, the
> pru cores are shut down and booted again, flushing out all the memories
> and start again in a clean state. Hence it is expected that the
> IEP_CMP_CFG register needs to be flushed during iep_init() to ensure
> that the existing residual configuration doesn't cause any unusual
> behavior. If the register is not cleared, existing IEP_CMP_CFG set for
> CMP1 will result in SYNC0_OUT signal based on the SYNC_OUT register values.
>
> After bringing the interface up, calling PPS enable doesn't work as
> the driver believes PPS is already enabled, (iep->pps_enabled is not
> cleared during interface bring down) and driver will just return true
> even though there is no signal. Fix this by disabling pps and perout.
>
> Fixes: c1e0230eeaab ("net: ti: icss-iep: Add IEP driver")
> Signed-off-by: Meghana Malladi <m-malladi@...com>
Reviewed-by: Roger Quadros <rogerq@...nel.org>
Powered by blists - more mailing lists