linux-kernel - Re: [PATCH v4 3/3] arm64: dts: qcom: x1e80100-vivobook-s15: Add bluetooth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <VE1P189MB1024A30BA75185CDB5FCEC91E32A2@VE1P189MB1024.EURP189.PROD.OUTLOOK.COM>
Date: Fri, 29 Nov 2024 16:44:26 +0100
From: Maud Spierings <maud_spierings@...mail.com>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Cc: Neil Armstrong <neil.armstrong@...aro.org>,
 Jessica Zhang <quic_jesszhan@...cinc.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Douglas Anderson
 <dianders@...omium.org>, Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>, dri-devel@...ts.freedesktop.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH v4 3/3] arm64: dts: qcom: x1e80100-vivobook-s15: Add
 bluetooth

On 11/25/24 11:29 PM, Dmitry Baryshkov wrote:
> On Mon, Nov 25, 2024 at 08:11:19PM +0100, Maud Spierings via B4 Relay wrote:
>> From: Maud Spierings <maud_spierings@...mail.com>
>>
>> Add bluetooth for the asus vivobook s15
>> Describe wlan configuration
>>
>> Signed-off-by: Maud Spierings <maud_spierings@...mail.com>
>> ---
>>   .../boot/dts/qcom/x1e80100-asus-vivobook-s15.dts   | 164 +++++++++++++++++++++
>>   1 file changed, 164 insertions(+)
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
>
I'm pretty sure I messed up the pinctrls in the wcn7850-pmu
I believe it should be:

pintctrl-0 = <&wcn_bt_en &wcn_wlan_en>;

instead of a seperate pinctrl-0 and 1
I'll fix this up  tomorrow/day after

Thanks for the review!

kind regards Maud