| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202411291225.18ZMjZcQ-lkp@intel.com>
Date: Fri, 29 Nov 2024 12:30:58 +0800
From: kernel test robot <lkp@...el.com>
To: Eliav Farber <farbere@...zon.com>, linux@...linux.org.uk,
catalin.marinas@....com, will@...nel.org, mpe@...erman.id.au,
npiggin@...il.com, christophe.leroy@...roup.eu, naveen@...nel.org,
maddy@...ux.ibm.com, paul.walmsley@...ive.com, palmer@...belt.com,
aou@...s.berkeley.edu, tglx@...utronix.de, ebiederm@...ssion.com,
akpm@...ux-foundation.org, bhe@...hat.com, hbathini@...ux.ibm.com,
sourabhjain@...ux.ibm.com, adityag@...ux.ibm.com,
songshuaishuai@...ylab.org, takakura@...inux.co.jp,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
linuxppc-dev@...ts.ozlabs.org, linux-riscv@...ts.infradead.org,
kexec@...ts.infradead.org
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev, jonnyc@...zon.com
Subject: Re: [PATCH v3 1/2] kexec: Consolidate
machine_kexec_mask_interrupts() implementation
Hi Eliav,
kernel test robot noticed the following build errors:
[auto build test ERROR on powerpc/next]
[also build test ERROR on powerpc/fixes tip/irq/core arm64/for-next/core linus/master v6.12 next-20241128]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Eliav-Farber/kexec-Consolidate-machine_kexec_mask_interrupts-implementation/20241129-041259
base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
patch link: https://lore.kernel.org/r/20241128201027.10396-2-farbere%40amazon.com
patch subject: [PATCH v3 1/2] kexec: Consolidate machine_kexec_mask_interrupts() implementation
config: x86_64-kexec (https://download.01.org/0day-ci/archive/20241129/202411291225.18ZMjZcQ-lkp@intel.com/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241129/202411291225.18ZMjZcQ-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411291225.18ZMjZcQ-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from kernel/kexec_core.c:9:
In file included from include/linux/btf.h:8:
In file included from include/linux/bpfptr.h:6:
In file included from include/linux/mm.h:2223:
include/linux/vmstat.h:504:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
504 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
505 | item];
| ~~~~
include/linux/vmstat.h:511:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
511 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
512 | NR_VM_NUMA_EVENT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~~
include/linux/vmstat.h:518:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
518 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
| ~~~~~~~~~~~ ^ ~~~
include/linux/vmstat.h:524:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
524 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
525 | NR_VM_NUMA_EVENT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~~
>> kernel/kexec_core.c:1085:10: error: call to undeclared function 'irq_desc_get_chip'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
1085 | chip = irq_desc_get_chip(desc);
| ^
>> kernel/kexec_core.c:1085:8: error: incompatible integer to pointer conversion assigning to 'struct irq_chip *' from 'int' [-Wint-conversion]
1085 | chip = irq_desc_get_chip(desc);
| ^ ~~~~~~~~~~~~~~~~~~~~~~~
>> kernel/kexec_core.c:1097:24: error: incomplete definition of type 'struct irq_chip'
1097 | if (check_eoi && chip->irq_eoi && irqd_irq_inprogress(&desc->irq_data))
| ~~~~^
kernel/kexec_core.c:1082:10: note: forward declaration of 'struct irq_chip'
1082 | struct irq_chip *chip;
| ^
>> kernel/kexec_core.c:1097:37: error: call to undeclared function 'irqd_irq_inprogress'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
1097 | if (check_eoi && chip->irq_eoi && irqd_irq_inprogress(&desc->irq_data))
| ^
>> kernel/kexec_core.c:1097:62: error: incomplete definition of type 'struct irq_desc'
1097 | if (check_eoi && chip->irq_eoi && irqd_irq_inprogress(&desc->irq_data))
| ~~~~^
include/linux/irqnr.h:10:15: note: forward declaration of 'struct irq_desc'
10 | extern struct irq_desc *irq_to_desc(unsigned int irq);
| ^
kernel/kexec_core.c:1098:8: error: incomplete definition of type 'struct irq_chip'
1098 | chip->irq_eoi(&desc->irq_data);
| ~~~~^
kernel/kexec_core.c:1082:10: note: forward declaration of 'struct irq_chip'
1082 | struct irq_chip *chip;
| ^
kernel/kexec_core.c:1098:23: error: incomplete definition of type 'struct irq_desc'
1098 | chip->irq_eoi(&desc->irq_data);
| ~~~~^
include/linux/irqnr.h:10:15: note: forward declaration of 'struct irq_desc'
10 | extern struct irq_desc *irq_to_desc(unsigned int irq);
| ^
kernel/kexec_core.c:1100:11: error: incomplete definition of type 'struct irq_chip'
1100 | if (chip->irq_mask)
| ~~~~^
kernel/kexec_core.c:1082:10: note: forward declaration of 'struct irq_chip'
1082 | struct irq_chip *chip;
| ^
kernel/kexec_core.c:1101:8: error: incomplete definition of type 'struct irq_chip'
1101 | chip->irq_mask(&desc->irq_data);
| ~~~~^
kernel/kexec_core.c:1082:10: note: forward declaration of 'struct irq_chip'
1082 | struct irq_chip *chip;
| ^
kernel/kexec_core.c:1101:24: error: incomplete definition of type 'struct irq_desc'
1101 | chip->irq_mask(&desc->irq_data);
| ~~~~^
include/linux/irqnr.h:10:15: note: forward declaration of 'struct irq_desc'
10 | extern struct irq_desc *irq_to_desc(unsigned int irq);
| ^
kernel/kexec_core.c:1103:11: error: incomplete definition of type 'struct irq_chip'
1103 | if (chip->irq_disable && !irqd_irq_disabled(&desc->irq_data))
| ~~~~^
kernel/kexec_core.c:1082:10: note: forward declaration of 'struct irq_chip'
1082 | struct irq_chip *chip;
| ^
kernel/kexec_core.c:1103:29: error: call to undeclared function 'irqd_irq_disabled'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
1103 | if (chip->irq_disable && !irqd_irq_disabled(&desc->irq_data))
| ^
kernel/kexec_core.c:1103:29: note: did you mean 'arch_irqs_disabled'?
arch/x86/include/asm/irqflags.h:145:28: note: 'arch_irqs_disabled' declared here
145 | static __always_inline int arch_irqs_disabled(void)
| ^
kernel/kexec_core.c:1103:52: error: incomplete definition of type 'struct irq_desc'
1103 | if (chip->irq_disable && !irqd_irq_disabled(&desc->irq_data))
| ~~~~^
include/linux/irqnr.h:10:15: note: forward declaration of 'struct irq_desc'
10 | extern struct irq_desc *irq_to_desc(unsigned int irq);
| ^
kernel/kexec_core.c:1104:8: error: incomplete definition of type 'struct irq_chip'
1104 | chip->irq_disable(&desc->irq_data);
| ~~~~^
kernel/kexec_core.c:1082:10: note: forward declaration of 'struct irq_chip'
1082 | struct irq_chip *chip;
| ^
kernel/kexec_core.c:1104:27: error: incomplete definition of type 'struct irq_desc'
1104 | chip->irq_disable(&desc->irq_data);
| ~~~~^
include/linux/irqnr.h:10:15: note: forward declaration of 'struct irq_desc'
10 | extern struct irq_desc *irq_to_desc(unsigned int irq);
| ^
4 warnings and 15 errors generated.
vim +/irq_desc_get_chip +1085 kernel/kexec_core.c
1075
1076 void machine_kexec_mask_interrupts(void)
1077 {
1078 unsigned int i;
1079 struct irq_desc *desc;
1080
1081 for_each_irq_desc(i, desc) {
1082 struct irq_chip *chip;
1083 int check_eoi = 1;
1084
> 1085 chip = irq_desc_get_chip(desc);
1086 if (!chip)
1087 continue;
1088
1089 if (IS_ENABLED(CONFIG_ARM64)) {
1090 /*
1091 * First try to remove the active state. If this fails, try to EOI the
1092 * interrupt.
1093 */
1094 check_eoi = irq_set_irqchip_state(i, IRQCHIP_STATE_ACTIVE, false);
1095 }
1096
> 1097 if (check_eoi && chip->irq_eoi && irqd_irq_inprogress(&desc->irq_data))
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists