| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202411291251.RwA1dKZL-lkp@intel.com>
Date: Fri, 29 Nov 2024 12:42:13 +0800
From: kernel test robot <lkp@...el.com>
To: Eliav Farber <farbere@...zon.com>, linux@...linux.org.uk,
catalin.marinas@....com, will@...nel.org, mpe@...erman.id.au,
npiggin@...il.com, christophe.leroy@...roup.eu, naveen@...nel.org,
maddy@...ux.ibm.com, paul.walmsley@...ive.com, palmer@...belt.com,
aou@...s.berkeley.edu, tglx@...utronix.de, ebiederm@...ssion.com,
akpm@...ux-foundation.org, bhe@...hat.com, hbathini@...ux.ibm.com,
sourabhjain@...ux.ibm.com, adityag@...ux.ibm.com,
songshuaishuai@...ylab.org, takakura@...inux.co.jp,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
linuxppc-dev@...ts.ozlabs.org, linux-riscv@...ts.infradead.org,
kexec@...ts.infradead.org
Cc: oe-kbuild-all@...ts.linux.dev, jonnyc@...zon.com
Subject: Re: [PATCH v3 2/2] kexec: Prevent redundant IRQ masking by checking
state before shutdown
Hi Eliav,
kernel test robot noticed the following build errors:
[auto build test ERROR on powerpc/next]
[also build test ERROR on powerpc/fixes tip/irq/core arm64/for-next/core linus/master v6.12 next-20241128]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Eliav-Farber/kexec-Consolidate-machine_kexec_mask_interrupts-implementation/20241129-041259
base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
patch link: https://lore.kernel.org/r/20241128201027.10396-3-farbere%40amazon.com
patch subject: [PATCH v3 2/2] kexec: Prevent redundant IRQ masking by checking state before shutdown
config: x86_64-rhel-9.4 (https://download.01.org/0day-ci/archive/20241129/202411291251.RwA1dKZL-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241129/202411291251.RwA1dKZL-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411291251.RwA1dKZL-lkp@intel.com/
All errors (new ones prefixed by >>):
kernel/kexec_core.c: In function 'machine_kexec_mask_interrupts':
kernel/kexec_core.c:1085:24: error: implicit declaration of function 'irq_desc_get_chip' [-Werror=implicit-function-declaration]
1085 | chip = irq_desc_get_chip(desc);
| ^~~~~~~~~~~~~~~~~
kernel/kexec_core.c:1085:22: warning: assignment to 'struct irq_chip *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
1085 | chip = irq_desc_get_chip(desc);
| ^
>> kernel/kexec_core.c:1086:31: error: implicit declaration of function 'irqd_is_started' [-Werror=implicit-function-declaration]
1086 | if (!chip || !irqd_is_started(&desc->irq_data))
| ^~~~~~~~~~~~~~~
kernel/kexec_core.c:1086:52: error: invalid use of undefined type 'struct irq_desc'
1086 | if (!chip || !irqd_is_started(&desc->irq_data))
| ^~
kernel/kexec_core.c:1097:38: error: invalid use of undefined type 'struct irq_chip'
1097 | if (check_eoi && chip->irq_eoi && irqd_irq_inprogress(&desc->irq_data))
| ^~
kernel/kexec_core.c:1097:51: error: implicit declaration of function 'irqd_irq_inprogress' [-Werror=implicit-function-declaration]
1097 | if (check_eoi && chip->irq_eoi && irqd_irq_inprogress(&desc->irq_data))
| ^~~~~~~~~~~~~~~~~~~
kernel/kexec_core.c:1097:76: error: invalid use of undefined type 'struct irq_desc'
1097 | if (check_eoi && chip->irq_eoi && irqd_irq_inprogress(&desc->irq_data))
| ^~
kernel/kexec_core.c:1098:29: error: invalid use of undefined type 'struct irq_chip'
1098 | chip->irq_eoi(&desc->irq_data);
| ^~
kernel/kexec_core.c:1098:44: error: invalid use of undefined type 'struct irq_desc'
1098 | chip->irq_eoi(&desc->irq_data);
| ^~
>> kernel/kexec_core.c:1100:17: error: implicit declaration of function 'irq_shutdown'; did you mean 'timer_shutdown'? [-Werror=implicit-function-declaration]
1100 | irq_shutdown(desc);
| ^~~~~~~~~~~~
| timer_shutdown
cc1: some warnings being treated as errors
vim +/irqd_is_started +1086 kernel/kexec_core.c
1075
1076 void machine_kexec_mask_interrupts(void)
1077 {
1078 unsigned int i;
1079 struct irq_desc *desc;
1080
1081 for_each_irq_desc(i, desc) {
1082 struct irq_chip *chip;
1083 int check_eoi = 1;
1084
1085 chip = irq_desc_get_chip(desc);
> 1086 if (!chip || !irqd_is_started(&desc->irq_data))
1087 continue;
1088
1089 if (IS_ENABLED(CONFIG_ARM64)) {
1090 /*
1091 * First try to remove the active state. If this fails, try to EOI the
1092 * interrupt.
1093 */
1094 check_eoi = irq_set_irqchip_state(i, IRQCHIP_STATE_ACTIVE, false);
1095 }
1096
1097 if (check_eoi && chip->irq_eoi && irqd_irq_inprogress(&desc->irq_data))
1098 chip->irq_eoi(&desc->irq_data);
1099
> 1100 irq_shutdown(desc);
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists