linux-kernel - Re: [PATCH v1 1/3] dt-bindings: iio: pressure: bmp085: Add SPI interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z0pTkhFJKPf2rBk0@vamoirid-laptop>
Date: Sat, 30 Nov 2024 00:51:46 +0100
From: Vasileios Amoiridis <vassilisamir@...il.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: jic23@...nel.org, lars@...afoo.de, robh@...nel.org, krzk+dt@...nel.org,
	conor+dt@...nel.org, andriy.shevchenko@...ux.intel.com,
	ajarizzo@...il.com, ak@...klinger.de, linux-iio@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/3] dt-bindings: iio: pressure: bmp085: Add SPI
 interface

On Fri, Nov 29, 2024 at 08:22:00AM +0100, Krzysztof Kozlowski wrote:
> On Fri, Nov 29, 2024 at 12:24:48AM +0100, Vasileios Amoiridis wrote:
> > @@ -73,6 +77,19 @@ allOf:
> >      then:
> >        properties:
> >          interrupts: false
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          not:
> > +            contains:
> > +              enum:
> 
> You have just two variants in this "not-containts", so invert your
> clause. Easier code.
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> 
> Best regards,
> Krzysztof
>

Hi Krzysztof,

Thank you very much for the review! I will fix it in the next version.

Cheers,
Vasilis