linux-kernel - Re: [PATCH v1 3/3] iio: pressure: bmp280: Make time vars intuitive and move to fsleep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z0pURIPAG4MHRYH3@vamoirid-laptop>
Date: Sat, 30 Nov 2024 00:54:44 +0100
From: Vasileios Amoiridis <vassilisamir@...il.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: jic23@...nel.org, lars@...afoo.de, robh@...nel.org, krzk+dt@...nel.org,
	conor+dt@...nel.org, ajarizzo@...il.com, ak@...klinger.de,
	linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 3/3] iio: pressure: bmp280: Make time vars intuitive
 and move to fsleep

On Fri, Nov 29, 2024 at 05:01:09PM +0200, Andy Shevchenko wrote:
> On Fri, Nov 29, 2024 at 12:24:50AM +0100, Vasileios Amoiridis wrote:
> > Add time unit abbreviation in the end of the variables to make the names
> > more intuitive. While at it, move to new fsleep().
> 
> Seems to me the commit message's primary and secondary purposes should be
> swapped, i.e. you do --> fsleep() conversions and while at it, rename variable.
> 
> -- 
> With Best Regards,
> Andy Shevchenko
> 
>

Hi Andy,

Thank you very much for the review! I can change that in next version.

Cheers,
Vasilis