linux-kernel - Re: rust/helpers/jump_label.c:10:5: sparse: sparse: symbol 'rust_helper_static_key_count' was not declared. Should it be static?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z0kPZwipai5thnw3@rli9-mobl>
Date: Fri, 29 Nov 2024 08:48:39 +0800
From: Philip Li <philip.li@...el.com>
To: Alice Ryhl <aliceryhl@...gle.com>
CC: kernel test robot <lkp@...el.com>, <oe-kbuild-all@...ts.linux.dev>,
	<linux-kernel@...r.kernel.org>, "Steven Rostedt (Google)"
	<rostedt@...dmis.org>, Boqun Feng <boqun.feng@...il.com>, Gary Guo
	<gary@...yguo.net>
Subject: Re: rust/helpers/jump_label.c:10:5: sparse: sparse: symbol
 'rust_helper_static_key_count' was not declared. Should it be static?

On Wed, Nov 27, 2024 at 01:07:24PM +0100, Alice Ryhl wrote:
> On Wed, Nov 27, 2024 at 3:38 AM kernel test robot <lkp@...el.com> wrote:
> >
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > head:   b50ecc5aca4d18f1f0c4942f5c797bc85edef144
> > commit: 6e59bcc9c8adec9a5bbedfa95a89946c56c510d9 rust: add static_branch_unlikely for static_key_false
> > date:   3 weeks ago
> > config: um-randconfig-r111-20241126 (https://download.01.org/0day-ci/archive/20241127/202411271011.gFsgMWRv-lkp@intel.com/config)
> > compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project 592c0fe55f6d9a811028b5f3507be91458ab2713)
> > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241127/202411271011.gFsgMWRv-lkp@intel.com/reproduce)
> >
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@...el.com>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202411271011.gFsgMWRv-lkp@intel.com/
> >
> > sparse warnings: (new ones prefixed by >>)
> >    rust/helpers/helpers.c: note: in included file:
> >    rust/helpers/helpers.c: note: in included file:
> >    rust/helpers/helpers.c: note: in included file:
> >    rust/helpers/helpers.c: note: in included file:
> >    rust/helpers/helpers.c: note: in included file:
> > >> rust/helpers/jump_label.c:10:5: sparse: sparse: symbol 'rust_helper_static_key_count' was not declared. Should it be static?
> >    rust/helpers/helpers.c: note: in included file:
> >    rust/helpers/helpers.c: note: in included file:
> >    rust/helpers/mutex.c:11:6: sparse: sparse: symbol 'rust_helper___mutex_init' was not declared. Should it be static?
> >    rust/helpers/helpers.c: note: in included file:
> >    rust/helpers/helpers.c: note: in included file:
> >    rust/helpers/helpers.c: note: in included file:
> >    rust/helpers/helpers.c: note: in included file:
> >    rust/helpers/helpers.c: note: in included file:
> >    rust/helpers/helpers.c: note: in included file:
> >    rust/helpers/helpers.c: note: in included file:
> >    rust/helpers/helpers.c: note: in included file:
> >    rust/helpers/helpers.c: note: in included file:
> >    rust/helpers/helpers.c: note: in included file:
> >    rust/helpers/helpers.c: note: in included file:
> >    rust/helpers/spinlock.c:16:6: sparse: sparse: context imbalance in 'rust_helper_spin_lock' - wrong count at exit
> >    rust/helpers/spinlock.c:21:6: sparse: sparse: context imbalance in 'rust_helper_spin_unlock' - unexpected unlock
> >
> > vim +/rust_helper_static_key_count +10 rust/helpers/jump_label.c
> >
> >      8
> >      9  #ifndef CONFIG_JUMP_LABEL
> >   > 10  int rust_helper_static_key_count(struct static_key *key)
> 
> Can we turn off sparse warnings for rust/helpers?

Got it, we will ignore the sparse warning for rust/helpers at bot side.

> 
> Alice
>