linux-kernel - Re: [PATCH 06/11] iio: light: vcnl4035: fix information leak in triggered buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241130205512.7a29ce90@jic23-huawei>
Date: Sat, 30 Nov 2024 20:55:12 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Javier Carrasco <javier.carrasco.cruz@...il.com>
Cc: Lars-Peter Clausen <lars@...afoo.de>, Antoni Pokusinski
 <apokusinski01@...il.com>, Francesco Dolcini <francesco@...cini.it>,
 João Paulo Gonçalves
 <jpaulo.silvagoncalves@...il.com>, Gregor Boirie
 <gregor.boirie@...rot.com>, Jonathan Cameron <Jonathan.Cameron@...wei.com>,
 linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org, João Paulo Gonçalves
 <joao.goncalves@...adex.com>, Francesco Dolcini
 <francesco.dolcini@...adex.com>, stable@...r.kernel.org
Subject: Re: [PATCH 06/11] iio: light: vcnl4035: fix information leak in
 triggered buffer

On Mon, 25 Nov 2024 22:16:14 +0100
Javier Carrasco <javier.carrasco.cruz@...il.com> wrote:

> The 'buffer' local array is used to push data to userspace from a
> triggered buffer, but it does not set an initial value for the single
> data element, which is an u16 aligned to 8 bytes. That leaves at least
> 4 bytes uninitialized even after writing an integer value with
> regmap_read().
> 
> Initialize the array to zero before using it to avoid pushing
> uninitialized information to userspace.
> 
> Cc: stable@...r.kernel.org
> Fixes: ec90b52c07c0 ("iio: light: vcnl4035: Fix buffer alignment in iio_push_to_buffers_with_timestamp()")
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@...il.com>
Applied.
> ---
>  drivers/iio/light/vcnl4035.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/light/vcnl4035.c b/drivers/iio/light/vcnl4035.c
> index 337a1332c2c6..67c94be02018 100644
> --- a/drivers/iio/light/vcnl4035.c
> +++ b/drivers/iio/light/vcnl4035.c
> @@ -105,7 +105,7 @@ static irqreturn_t vcnl4035_trigger_consumer_handler(int irq, void *p)
>  	struct iio_dev *indio_dev = pf->indio_dev;
>  	struct vcnl4035_data *data = iio_priv(indio_dev);
>  	/* Ensure naturally aligned timestamp */
> -	u8 buffer[ALIGN(sizeof(u16), sizeof(s64)) + sizeof(s64)]  __aligned(8);
> +	u8 buffer[ALIGN(sizeof(u16), sizeof(s64)) + sizeof(s64)]  __aligned(8) = { };
>  	int ret;
>  
>  	ret = regmap_read(data->regmap, VCNL4035_ALS_DATA, (int *)buffer);
>