linux-kernel - Re: [PATCH 05/11] iio: imu: kmx61: fix information leak in triggered buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241130205622.6bc2339e@jic23-huawei>
Date: Sat, 30 Nov 2024 20:56:22 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Javier Carrasco <javier.carrasco.cruz@...il.com>
Cc: Lars-Peter Clausen <lars@...afoo.de>, Antoni Pokusinski
 <apokusinski01@...il.com>, Francesco Dolcini <francesco@...cini.it>,
 João Paulo Gonçalves
 <jpaulo.silvagoncalves@...il.com>, Gregor Boirie
 <gregor.boirie@...rot.com>, Jonathan Cameron <Jonathan.Cameron@...wei.com>,
 linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org, João Paulo Gonçalves
 <joao.goncalves@...adex.com>, Francesco Dolcini
 <francesco.dolcini@...adex.com>, stable@...r.kernel.org
Subject: Re: [PATCH 05/11] iio: imu: kmx61: fix information leak in
 triggered buffer

On Mon, 25 Nov 2024 22:16:13 +0100
Javier Carrasco <javier.carrasco.cruz@...il.com> wrote:

> The 'buffer' local array is used to push data to user space from a
> triggered buffer, but it does not set values for inactive channels, as
> it only uses iio_for_each_active_channel() to assign new values.
> 
> Initialize the array to zero before using it to avoid pushing
> uninitialized information to userspace.
> 
> Cc: stable@...r.kernel.org
> Fixes: c3a23ecc0901 ("iio: imu: kmx61: Add support for data ready triggers")
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@...il.com>
Applied.
> ---
>  drivers/iio/imu/kmx61.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/imu/kmx61.c b/drivers/iio/imu/kmx61.c
> index 324c38764656..e19c5d3137c6 100644
> --- a/drivers/iio/imu/kmx61.c
> +++ b/drivers/iio/imu/kmx61.c
> @@ -1193,7 +1193,7 @@ static irqreturn_t kmx61_trigger_handler(int irq, void *p)
>  	struct kmx61_data *data = kmx61_get_data(indio_dev);
>  	int bit, ret, i = 0;
>  	u8 base;
> -	s16 buffer[8];
> +	s16 buffer[8] = { };
>  
>  	if (indio_dev == data->acc_indio_dev)
>  		base = KMX61_ACC_XOUT_L;
>