[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAA8EJpqyQ32TNr-_0owXqbCzbwRcr7enmUV2TYoX3yWHz-Vn4A@mail.gmail.com>
Date: Sun, 1 Dec 2024 10:08:56 +0200
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Tingguo Cheng <quic_tingguoc@...cinc.com>
Cc: quic_fenglinw@...cinc.com, quic_tingweiz@...cinc.com, kernel@...cinc.com,
Bjorn Andersson <andersson@...nel.org>, Konrad Dybcio <konradybcio@...nel.org>,
Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/2] Adds SPMI bus, PMIC and peripherals for qcs8300-ride
On Sun, 1 Dec 2024 at 09:13, Tingguo Cheng <quic_tingguoc@...cinc.com> wrote:
>
>
>
> On 11/28/2024 9:10 PM, Dmitry Baryshkov wrote:
> > On Thu, Nov 28, 2024 at 05:40:15PM +0800, Tingguo Cheng wrote:
> >> Enable SPMI bus, PMIC and PMIC peripherals for qcs8300-ride board. The
> >> qcs8300-ride use 2 pmics(pmm8620au:0,pmm8650au:1) on the board, which
> >> are variants of pmm8654au used on sa8775p/qcs9100 -ride(4x pmics).
> >>
> >> This patch series depends on the patch series:
> >> https://lore.kernel.org/all/20240925-qcs8300_initial_dtsi-v2-0-494c40fa2a42@quicinc.com/
> >>
> >> Signed-off-by: Tingguo Cheng <quic_tingguoc@...cinc.com>
> >> ---
> >> Changes in v2:
> >> - Fixed comments in community.
> >
> > comments in community? What does that mean?
> Comments given by the opensource community in the Email list. Sorry for
> not being clear about this.
Please in future describe your changes in changelog. Saying 'fixed
review comments' is not enough, as it's hard to tell, what was
actually changed and what wasn't.
> >
> >> - Added arbiter version(5.2.0) in commit message.
> >> - Link to v1: https://lore.kernel.org/r/20241126-adds-spmi-pmic-peripherals-for-qcs8300-v1-0-28af84cb86f8@quicinc.com
> >>
> >> ---
> >> Tingguo Cheng (2):
> >> arm64: dts: qcom: qcs8300: Adds SPMI support
> >> arm64: dts: qcom: qcs8300-ride: Enable PMIC peripherals
> >>
> >> arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 23 +++++++++++++++++++++++
> >> arch/arm64/boot/dts/qcom/qcs8300.dtsi | 22 ++++++++++++++++++++++
> >> 2 files changed, 45 insertions(+)
> >> ---
> >> base-commit: decc701f41d07481893fdea942c0ac6b226e84cd
> >> change-id: 20241122-adds-spmi-pmic-peripherals-for-qcs8300-0a3c4458cf7e
> >> prerequisite-change-id: 20240925-qcs8300_initial_dtsi-ea614fe45341:v2
> >> prerequisite-patch-id: 73c78f31fa1d504124d4a82b578a6a14126cccd8
> >> prerequisite-patch-id: 5a01283c8654ae7c696d9c69cb21505b71c5ca27
> >> prerequisite-patch-id: dc633d5aaac790776a8a213ea2faa4890a3f665d
> >> prerequisite-patch-id: 9ecf4cb8b5842ac64e51d6baa0e6c1fbe449ee66
> >>
> >> Best regards,
> >> --
> >> Tingguo Cheng <quic_tingguoc@...cinc.com>
> >>
> >
>
> --
> Thank you & BRs
> Tingguo
>
--
With best wishes
Dmitry
Powered by blists - more mailing lists