linux-kernel - drivers/irqchip/irq-ath79-cpu.c:92:13: sparse: sparse: symbol 'ath79_cpu_irq_init' was not declared. Should it be static?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202412011509.kGQkDr1y-lkp@intel.com>
Date: Sun, 1 Dec 2024 16:06:46 +0800
From: kernel test robot <lkp@...el.com>
To: John Crispin <john@...ozen.org>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
	Paul Burton <paul.burton@...s.com>
Subject: drivers/irqchip/irq-ath79-cpu.c:92:13: sparse: sparse: symbol
 'ath79_cpu_irq_init' was not declared. Should it be static?

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   bcc8eda6d34934d80b96adb8dc4ff5dfc632a53a
commit: 51fa4f8912c0934cf1410f435516d2abbcf88a9e MIPS: ath79: drop legacy IRQ code
date:   6 years ago
config: mips-randconfig-r122-20241119 (https://download.01.org/0day-ci/archive/20241201/202412011509.kGQkDr1y-lkp@intel.com/config)
compiler: mips-linux-gcc (GCC) 14.2.0
reproduce: (https://download.01.org/0day-ci/archive/20241201/202412011509.kGQkDr1y-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412011509.kGQkDr1y-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
>> drivers/irqchip/irq-ath79-cpu.c:92:13: sparse: sparse: symbol 'ath79_cpu_irq_init' was not declared. Should it be static?

vim +/ath79_cpu_irq_init +92 drivers/irqchip/irq-ath79-cpu.c

81ffb18ce4a0c4 Alban Bedel 2016-01-23  58  
81ffb18ce4a0c4 Alban Bedel 2016-01-23  59  static int __init ar79_cpu_intc_of_init(
81ffb18ce4a0c4 Alban Bedel 2016-01-23  60  	struct device_node *node, struct device_node *parent)
81ffb18ce4a0c4 Alban Bedel 2016-01-23  61  {
81ffb18ce4a0c4 Alban Bedel 2016-01-23  62  	int err, i, count;
81ffb18ce4a0c4 Alban Bedel 2016-01-23  63  
81ffb18ce4a0c4 Alban Bedel 2016-01-23  64  	/* Fill the irq_wb_chan table */
81ffb18ce4a0c4 Alban Bedel 2016-01-23  65  	count = of_count_phandle_with_args(
81ffb18ce4a0c4 Alban Bedel 2016-01-23  66  		node, "qca,ddr-wb-channels", "#qca,ddr-wb-channel-cells");
81ffb18ce4a0c4 Alban Bedel 2016-01-23  67  
81ffb18ce4a0c4 Alban Bedel 2016-01-23  68  	for (i = 0; i < count; i++) {
81ffb18ce4a0c4 Alban Bedel 2016-01-23  69  		struct of_phandle_args args;
81ffb18ce4a0c4 Alban Bedel 2016-01-23  70  		u32 irq = i;
81ffb18ce4a0c4 Alban Bedel 2016-01-23  71  
81ffb18ce4a0c4 Alban Bedel 2016-01-23  72  		of_property_read_u32_index(
81ffb18ce4a0c4 Alban Bedel 2016-01-23  73  			node, "qca,ddr-wb-channel-interrupts", i, &irq);
81ffb18ce4a0c4 Alban Bedel 2016-01-23  74  		if (irq >= ARRAY_SIZE(irq_wb_chan))
81ffb18ce4a0c4 Alban Bedel 2016-01-23  75  			continue;
81ffb18ce4a0c4 Alban Bedel 2016-01-23  76  
81ffb18ce4a0c4 Alban Bedel 2016-01-23  77  		err = of_parse_phandle_with_args(
81ffb18ce4a0c4 Alban Bedel 2016-01-23  78  			node, "qca,ddr-wb-channels",
81ffb18ce4a0c4 Alban Bedel 2016-01-23  79  			"#qca,ddr-wb-channel-cells",
81ffb18ce4a0c4 Alban Bedel 2016-01-23  80  			i, &args);
81ffb18ce4a0c4 Alban Bedel 2016-01-23  81  		if (err)
81ffb18ce4a0c4 Alban Bedel 2016-01-23  82  			return err;
81ffb18ce4a0c4 Alban Bedel 2016-01-23  83  
81ffb18ce4a0c4 Alban Bedel 2016-01-23  84  		irq_wb_chan[irq] = args.args[0];
81ffb18ce4a0c4 Alban Bedel 2016-01-23  85  	}
81ffb18ce4a0c4 Alban Bedel 2016-01-23  86  
81ffb18ce4a0c4 Alban Bedel 2016-01-23  87  	return mips_cpu_irq_of_init(node, parent);
81ffb18ce4a0c4 Alban Bedel 2016-01-23  88  }
81ffb18ce4a0c4 Alban Bedel 2016-01-23  89  IRQCHIP_DECLARE(ar79_cpu_intc, "qca,ar7100-cpu-intc",
81ffb18ce4a0c4 Alban Bedel 2016-01-23  90  		ar79_cpu_intc_of_init);
81ffb18ce4a0c4 Alban Bedel 2016-01-23  91  
81ffb18ce4a0c4 Alban Bedel 2016-01-23 @92  void __init ath79_cpu_irq_init(unsigned irq_wb_chan2, unsigned irq_wb_chan3)

:::::: The code at line 92 was first introduced by commit
:::::: 81ffb18ce4a0c400b051c3df67e452410d6be1ec irqchip/ath79-cpu: Move the CPU IRQ driver from arch/mips/ath79/

:::::: TO: Alban Bedel <albeu@...e.fr>
:::::: CC: Jason Cooper <jason@...edaemon.net>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki