linux-kernel - Re: [GIT PULL] Staging driver changes for 6.13-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c92efa1b-7353-4e54-982d-9d861fe36e68@roeck-us.net>
Date: Mon, 2 Dec 2024 09:02:25 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Dave Penkler <dpenkler@...il.com>
Cc: Greg KH <gregkh@...uxfoundation.org>,
 Linus Torvalds <torvalds@...ux-foundation.org>,
 Andrew Morton <akpm@...ux-foundation.org>,
 Stephen Rothwell <sfr@...b.auug.org.au>, linux-kernel@...r.kernel.org,
 linux-staging@...ts.linux.dev
Subject: Re: [GIT PULL] Staging driver changes for 6.13-rc1

On 12/2/24 07:35, Dave Penkler wrote:
> On Mon, Dec 02, 2024 at 06:52:28AM -0800, Guenter Roeck wrote:
>> On Mon, Dec 02, 2024 at 10:50:07AM +0100, Dave Penkler wrote:
>> [ ... ]
>>> That is weird: the type of resource.start is resource_size_t which resolves to u32 via phys_addr_t on i386 which should be the same size as void *
>>> For compile check purposes simply changing iobase type to phys_addr_t the following error message appears:
>>>
>>> drivers/staging/gpib/ines/ines_gpib.c: In function 'ines_common_pci_attach':
>>> drivers/staging/gpib/ines/ines_gpib.c:783:28: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
>>>    783 |         nec_priv->iobase = (void *)(pci_resource_start(ines_priv->pci_device,
>>>        |                            ^
>>> drivers/staging/gpib/ines/ines_gpib.c:783:26: error: assignment to 'phys_addr_t' {aka 'long long unsigned int'} from 'void *' makes integer from pointer without a cast [-Wint-conversion]
>>>    783 |         nec_priv->iobase = (void *)(pci_resource_start(ines_priv->pci_device,
>>>        |                          ^
>>>
>>> It would seem that for some reason phys_addr_t resolves to long long unsigned int
>>
>> Check out CONFIG_X86_PAE, which adds 64-bit physical address support to
>> 32-bit x86 images. Pointers are still 32 bit in that mode, though.
>>
>> Guenter
> OK thanks. I will submit a patch to use ioremap.
> -Dave

FWIW, I applied the following patch (hack) to my fixes branch to get around
the build problem.

Guenter

---
diff --git a/drivers/staging/gpib/Kconfig b/drivers/staging/gpib/Kconfig
index 9ee432316465..a9fe2920d5c0 100644
--- a/drivers/staging/gpib/Kconfig
+++ b/drivers/staging/gpib/Kconfig
@@ -1,6 +1,7 @@
  # SPDX-License-Identifier: GPL-2.0
  menuconfig GPIB
         tristate "Linux GPIB drivers"
+       depends on !X86_PAE
         help
           Enable support for GPIB cards and dongles for Linux.  GPIB
           is the General Purpose Interface Bus which conforms to the