linux-kernel - Re: [PATCH] platform/mellanox: mlxbf-pmc: incorrect type in assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <364568ce-140a-85f5-4bf4-1cc641175015@linux.intel.com>
Date: Mon, 2 Dec 2024 19:16:06 +0200 (EET)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Pei Xiao <xiaopei01@...inos.cn>
cc: Hans de Goede <hdegoede@...hat.com>, vadimp@...dia.com, 
    platform-driver-x86@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>, 
    davthompson@...dia.com, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] platform/mellanox: mlxbf-pmc: incorrect type in
 assignment

On Wed, 20 Nov 2024, Pei Xiao wrote:

> sparse warning,expected 'void __iomem *addr',but got 'void *addr'

Hi,

Thanks for the patch. I've applied this patch to review-ilpo-next branch 
but I had to reformat the commit message. Please make sure you use proper 
spacing and put warnings like that on their own lines in future.

-- 
 i.

> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202411121935.cgFcEMO4-lkp@intel.com/
> Fixes: 423c3361855c ("platform/mellanox: mlxbf-pmc: Add support for BlueField-3")
> Signed-off-by: Pei Xiao <xiaopei01@...inos.cn>
> ---
>  drivers/platform/mellanox/mlxbf-pmc.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/platform/mellanox/mlxbf-pmc.c b/drivers/platform/mellanox/mlxbf-pmc.c
> index 9d18dfca6a67..9ff7b487dc48 100644
> --- a/drivers/platform/mellanox/mlxbf-pmc.c
> +++ b/drivers/platform/mellanox/mlxbf-pmc.c
> @@ -1168,7 +1168,7 @@ static int mlxbf_pmc_program_l3_counter(unsigned int blk_num, u32 cnt_num, u32 e
>  /* Method to handle crspace counter programming */
>  static int mlxbf_pmc_program_crspace_counter(unsigned int blk_num, u32 cnt_num, u32 evt)
>  {
> -	void *addr;
> +	void __iomem *addr;
>  	u32 word;
>  	int ret;
>  
> @@ -1192,7 +1192,7 @@ static int mlxbf_pmc_program_crspace_counter(unsigned int blk_num, u32 cnt_num,
>  /* Method to clear crspace counter value */
>  static int mlxbf_pmc_clear_crspace_counter(unsigned int blk_num, u32 cnt_num)
>  {
> -	void *addr;
> +	void __iomem *addr;
>  
>  	addr = pmc->block[blk_num].mmio_base +
>  		MLXBF_PMC_CRSPACE_PERFMON_VAL0(pmc->block[blk_num].counters) +
> @@ -1405,7 +1405,7 @@ static int mlxbf_pmc_read_l3_event(unsigned int blk_num, u32 cnt_num, u64 *resul
>  static int mlxbf_pmc_read_crspace_event(unsigned int blk_num, u32 cnt_num, u64 *result)
>  {
>  	u32 word, evt;
> -	void *addr;
> +	void __iomem *addr;
>  	int ret;
>  
>  	addr = pmc->block[blk_num].mmio_base +
>