linux-kernel - Re: [PATCH 12/15] platform/x86: quickstart: don't include 'pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <35cd3752-9378-69e3-8da9-7f47dfd127d0@linux.intel.com>
Date: Mon, 2 Dec 2024 19:17:16 +0200 (EET)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Wolfram Sang <wsa+renesas@...g-engineering.com>
cc: LKML <linux-kernel@...r.kernel.org>, Armin Wolf <W_Armin@....de>, 
    Hans de Goede <hdegoede@...hat.com>, platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH 12/15] platform/x86: quickstart: don't include 'pm_wakeup.h'
 directly

On Mon, 18 Nov 2024, Wolfram Sang wrote:

> The header clearly states that it does not want to be included directly,
> only via 'device.h'. 'platform_device.h' works equally well. Remove the
> direct inclusion.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@...g-engineering.com>
> ---
>  drivers/platform/x86/quickstart.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/quickstart.c b/drivers/platform/x86/quickstart.c
> index 8d540a1c8602..c332c7cdaff5 100644
> --- a/drivers/platform/x86/quickstart.c
> +++ b/drivers/platform/x86/quickstart.c
> @@ -20,7 +20,6 @@
>  #include <linux/module.h>
>  #include <linux/mutex.h>
>  #include <linux/platform_device.h>
> -#include <linux/pm_wakeup.h>
>  #include <linux/printk.h>
>  #include <linux/slab.h>
>  #include <linux/sysfs.h>

Thanks for the patch. I've applied it to the review-ilpo-next branch in 
the pdx86 repo.

-- 
 i.