linux-kernel - Re: [PATCH v2] kdb: utilize more readable control characters macro in kdb io

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAD=FV=XO6dvRHvu0tn=Vb6Eb4B4R-1rXA-==9vY-euZwyk7T_w@mail.gmail.com>
Date: Mon, 2 Dec 2024 09:19:25 -0800
From: Doug Anderson <dianders@...omium.org>
To: Nir Lichtman <nir@...htman.org>
Cc: jason.wessel@...driver.com, danielt@...nel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] kdb: utilize more readable control characters macro in
 kdb io

Hi,

On Thu, Nov 28, 2024 at 12:35 PM Nir Lichtman <nir@...htman.org> wrote:
>
> Continuing the previous refactor in kdb_keyboard.c of adding the CTRL
> macro, this patch moves the macro to a common header and utilizes this
> pattern in kdb_io.c as well, resulting in more readable code.
>
> I have added the _KEY suffix to make the macro more clear, considering
> it is now common.
>
> Signed-off-by: Nir Lichtman <nir@...htman.org>
> ---
>
> v2: Refactor another line CTRL+I line I missed in v1 and remove CTRL+K/U
> I accidentaly included in v1.
>
>  kernel/debug/kdb/kdb_io.c       | 38 ++++++++++++++++-----------------
>  kernel/debug/kdb/kdb_keyboard.c | 34 ++++++++++++++---------------
>  kernel/debug/kdb/kdb_private.h  |  2 ++
>  3 files changed, 37 insertions(+), 37 deletions(-)

Reviewed-by: Douglas Anderson <dianders@...omium.org>