linux-kernel - Re: [PATCH v2] [MIPS] Place __kernel_entry at the beginning of text section

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.2412021751110.30050@angie.orcam.me.uk>
Date: Mon, 2 Dec 2024 17:58:00 +0000 (GMT)
From: "Maciej W. Rozycki" <macro@...am.me.uk>
To: Rong Xu <xur@...gle.com>
cc: Thomas Bogendoerfer <tsbogend@...ha.franken.de>, 
    Masahiro Yamada <masahiroy@...nel.org>, 
    Klara Modin <klarasmodin@...il.com>, 
    Christophe Leroy <christophe.leroy@...roup.eu>, 
    Michael Ellerman <mpe@...erman.id.au>, Nicolas Schier <nicolas@...sle.eu>, 
    Chris Packham <chris.packham@...iedtelesis.co.nz>, 
    linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] [MIPS] Place __kernel_entry at the beginning of text
 section

On Tue, 26 Nov 2024, Rong Xu wrote:

> diff --git a/arch/mips/kernel/head.S b/arch/mips/kernel/head.S
> index e90695b2b60e..c7528d96dd1a 100644
> --- a/arch/mips/kernel/head.S
> +++ b/arch/mips/kernel/head.S
> @@ -59,6 +59,7 @@
>  #endif
>  	.endm
>  
> +	__HEAD
>  #ifndef CONFIG_NO_EXCEPT_FILL
>  	/*
>  	 * Reserved space for exception handlers.

 A new line would be preferable afterwards so as to visually separate the 
directive from the conditional part that follows.  It looks messy as it 
stands (and we have prior art further down the file with __REF).  Please 
send a fix.

  Maciej