[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAF1bQ=QRYu5-CY_r7wUcku9WT8sXmD47VW42eHWGNE3bZfr4Dw@mail.gmail.com>
Date: Mon, 2 Dec 2024 10:20:42 -0800
From: Rong Xu <xur@...gle.com>
To: "Maciej W. Rozycki" <macro@...am.me.uk>
Cc: Thomas Bogendoerfer <tsbogend@...ha.franken.de>, Masahiro Yamada <masahiroy@...nel.org>,
Klara Modin <klarasmodin@...il.com>, Christophe Leroy <christophe.leroy@...roup.eu>,
Michael Ellerman <mpe@...erman.id.au>, Nicolas Schier <nicolas@...sle.eu>,
Chris Packham <chris.packham@...iedtelesis.co.nz>, linux-mips@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] [MIPS] Place __kernel_entry at the beginning of text section
Sure. I'll send a separate patch for this format change (not v3 as
this patch was already submitted).
Thanks!
-Rong
On Mon, Dec 2, 2024 at 9:58 AM Maciej W. Rozycki <macro@...am.me.uk> wrote:
>
> On Tue, 26 Nov 2024, Rong Xu wrote:
>
> > diff --git a/arch/mips/kernel/head.S b/arch/mips/kernel/head.S
> > index e90695b2b60e..c7528d96dd1a 100644
> > --- a/arch/mips/kernel/head.S
> > +++ b/arch/mips/kernel/head.S
> > @@ -59,6 +59,7 @@
> > #endif
> > .endm
> >
> > + __HEAD
> > #ifndef CONFIG_NO_EXCEPT_FILL
> > /*
> > * Reserved space for exception handlers.
>
> A new line would be preferable afterwards so as to visually separate the
> directive from the conditional part that follows. It looks messy as it
> stands (and we have prior art further down the file with __REF). Please
> send a fix.
>
> Maciej
Powered by blists - more mailing lists