linux-kernel - Re: [PATCH v8 1/2] cacheinfo: Allocate memory during CPU hotplug if not done from the primary CPU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f9753978-6505-43ad-a224-a78ab5141f45@suse.com>
Date: Mon, 2 Dec 2024 08:53:44 +0200
From: Nikolay Borisov <nik.borisov@...e.com>
To: Ricardo Neri <ricardo.neri-calderon@...ux.intel.com>, x86@...nel.org
Cc: Andreas Herrmann <aherrmann@...e.com>,
 Catalin Marinas <catalin.marinas@....com>, Chen Yu <yu.c.chen@...el.com>,
 Len Brown <len.brown@...el.com>, Radu Rendec <rrendec@...hat.com>,
 Pierre Gondois <Pierre.Gondois@....com>, Pu Wen <puwen@...on.cn>,
 "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
 Sudeep Holla <sudeep.holla@....com>,
 Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
 Will Deacon <will@...nel.org>, Zhang Rui <rui.zhang@...el.com>,
 Huang Ying <ying.huang@...el.com>, Ricardo Neri <ricardo.neri@...el.com>,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v8 1/2] cacheinfo: Allocate memory during CPU hotplug if
 not done from the primary CPU



On 28.11.24 г. 2:22 ч., Ricardo Neri wrote:
> Commit 5944ce092b97 ("arch_topology: Build cacheinfo from primary CPU")
> adds functionality that architectures can use to optionally allocate and
> build cacheinfo early during boot. Commit 6539cffa9495 ("cacheinfo: Add
> arch specific early level initializer") lets secondary CPUs correct (and
> reallocate memory) cacheinfo data if needed.
> 
> If the early build functionality is not used and cacheinfo does not need
> correction, memory for cacheinfo is never allocated. x86 does not use the
> early build functionality. Consequently, during the cacheinfo CPU hotplug
> callback, last_level_cache_is_valid() attempts to dereference a NULL
> pointer:
> 
>       BUG: kernel NULL pointer dereference, address: 0000000000000100
>       #PF: supervisor read access in kernel mode
>       #PF: error_code(0x0000) - not present page
>       PGD 0 P4D 0
>       Oops: 0000 [#1] PREEPMT SMP NOPTI
>       CPU: 0 PID 19 Comm: cpuhp/0 Not tainted 6.4.0-rc2 #1
>       RIP: 0010: last_level_cache_is_valid+0x95/0xe0a
> 
> Allocate memory for cacheinfo during the cacheinfo CPU hotplug callback if
> not done earlier.
> 
> Moreover, before determining the validity of the last-level cache info,
> ensure that it has been allocated. Simply checking for non-zero
> cache_leaves() is not sufficient, as some architectures (e.g., Intel
> processors) have non-zero cache_leaves() before allocation.
> 
> Dereferencing NULL cacheinfo can occur in update_per_cpu_data_slice_size().
> This function iterates over all online CPUs. However, a CPU may have come
> online recently, but its cacheinfo may not have been allocated yet.
> 
> While here, remove an unnecessary indentation in allocate_cache_info().
> 
> Reviewed-by: Andreas Herrmann <aherrmann@...e.de>
> Reviewed-by: Nikolay Borisov <nik.borisov@...e.com>
> Reviewed-by: Radu Rendec <rrendec@...hat.com>
> Reviewed-by: Sudeep Holla <sudeep.holla@....com>
> Tested-by: Andreas Herrmann <aherrmann@...e.de>
> Fixes: 6539cffa9495 ("cacheinfo: Add arch specific early level initializer")
> Signed-off-by: Ricardo Neri <ricardo.neri-calderon@...ux.intel.com>


Reviewed-by: Nikolay Borisov <nik.borisov@...e.com>