linux-kernel - Re: [PATCH AUTOSEL 5.10 3/6] can: j1939: fix error in J1939 documentation.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z02hGYbHhkEeE3eQ@duo.ucw.cz>
Date: Mon, 2 Dec 2024 12:59:21 +0100
From: Pavel Machek <pavel@....cz>
To: Sasha Levin <sashal@...nel.org>
Cc: linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	Alexander Hölzl <alexander.hoelzl@....net>,
	Oleksij Rempel <o.rempel@...gutronix.de>,
	Vincent Mailhol <mailhol.vincent@...adoo.fr>,
	Marc Kleine-Budde <mkl@...gutronix.de>, robin@...tonic.nl,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, corbet@....net, linux-can@...r.kernel.org,
	netdev@...r.kernel.org, linux-doc@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 5.10 3/6] can: j1939: fix error in J1939
 documentation.

Hi!

> From: Alexander Hölzl <alexander.hoelzl@....net>
> 
> [ Upstream commit b6ec62e01aa4229bc9d3861d1073806767ea7838 ]
> 
> The description of PDU1 format usage mistakenly referred to PDU2
> format.

I'm pretty sure this does not fix user-visible bug.

BR,
								Pavel

> Signed-off-by: Alexander Hölzl <alexander.hoelzl@....net>
> Acked-by: Oleksij Rempel <o.rempel@...gutronix.de>
> Acked-by: Vincent Mailhol <mailhol.vincent@...adoo.fr>
> Link: https://patch.msgid.link/20241023145257.82709-1-alexander.hoelzl@gmx.net
> Signed-off-by: Marc Kleine-Budde <mkl@...gutronix.de>
> Signed-off-by: Sasha Levin <sashal@...nel.org>
> ---
>  Documentation/networking/j1939.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/networking/j1939.rst b/Documentation/networking/j1939.rst
> index 0a4b73b03b997..59f81ba411608 100644
> --- a/Documentation/networking/j1939.rst
> +++ b/Documentation/networking/j1939.rst
> @@ -83,7 +83,7 @@ format, the Group Extension is set in the PS-field.
>  
>  On the other hand, when using PDU1 format, the PS-field contains a so-called
>  Destination Address, which is _not_ part of the PGN. When communicating a PGN
> -from user space to kernel (or vice versa) and PDU2 format is used, the PS-field
> +from user space to kernel (or vice versa) and PDU1 format is used, the PS-field
>  of the PGN shall be set to zero. The Destination Address shall be set
>  elsewhere.
>  

-- 
People of Russia, stop Putin before his war on Ukraine escalates.

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)