[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <d2ac47d2-3c7d-4d22-918c-12693ce1a60e@oss.nxp.com>
Date: Mon, 2 Dec 2024 14:25:14 +0200
From: Ciprian Marian Costea <ciprianmarian.costea@....nxp.com>
To: Krzysztof Kozlowski <krzk@...nel.org>,
Marc Kleine-Budde <mkl@...gutronix.de>,
Vincent Mailhol <mailhol.vincent@...adoo.fr>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Cc: linux-can@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, NXP S32 Linux <s32@....com>,
imx@...ts.linux.dev, Christophe Lizzi <clizzi@...hat.com>,
Alberto Ruiz <aruizrui@...hat.com>, Enric Balletbo <eballetb@...hat.com>
Subject: Re: [PATCH v3 1/3] dt-bindings: can: fsl,flexcan: add S32G2/S32G3 SoC
support
On 11/29/2024 6:05 PM, Krzysztof Kozlowski wrote:
> On 29/11/2024 15:25, Ciprian Costea wrote:
>> + properties:
>> + interrupts:
>> + items:
>> + - description: Message Buffer interrupt for mailboxes 0-7 and Enhanced RX FIFO
>> + - description: Device state change
>> + - description: Error detection
>> + - description: Message Buffer interrupt for mailboxes 8-127
>> + interrupt-names:
>> + items:
>> + - const: mb-0
>> + - const: state
>> + - const: berr
>> + - const: mb-1
>> + required:
>> + - compatible
>> + - reg
>
>
> Drop, aren't they already required?
>
Yes, I was not sure if 'required' here overrides or appends the items to
the 'global' required declaration.
Now I know it appends them, so I will only keep 'interrupt-names'. Thanks.
>> + - interrupts
>> + - interrupt-names
>> + else:
>> + properties:
>> + interrupts:
>> + maxItems: 1
>
>
> Missing constraints for interrupt-names, e.g. :false.
>
Correct, I will add 'interrupt-names' constraint in V4.
>
>> +
>> additionalProperties: false
>>
>> examples:
>
>
> Best regards,
> Krzysztof
Best Regards,
Ciprian
Powered by blists - more mailing lists